Skip to content

fix(tasks): task compose close button fix#906

Merged
sedson merged 2 commits intomainfrom
seamus/fix-task-compose-close-bttn
Jan 12, 2026
Merged

fix(tasks): task compose close button fix#906
sedson merged 2 commits intomainfrom
seamus/fix-task-compose-close-bttn

Conversation

@sedson
Copy link
Copy Markdown
Contributor

@sedson sedson commented Jan 9, 2026

Summary

Screenshots, GIFs, and Videos

@sedson sedson requested a review from a team as a code owner January 9, 2026 22:16
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 9, 2026

@claude
Copy link
Copy Markdown
Contributor

claude bot commented Jan 9, 2026

Code review

Missing test coverage for bug fix

File: js/app/packages/block-md/component/ComposeTask.tsx

This PR fixes a bug with the task compose close button, but no tests were added to verify the fix or prevent regression.

According to CLAUDE.md line 11:

Testing - Write tests for your changes. When fixing bugs or regressions, identify the issue with a test before fixing it.

Consider adding tests that:

  1. Verify the split panel closes correctly when creating a task without "create more"
  2. Verify the split panel closes when handleClose is called
  3. Ensure the close button works in all scenarios (popover and non-popover contexts)

Changed code:

if (!createMore()) {
splitPanel.handle.close();
props.onCreateTask?.(taskTitle, taskContent);
props.onClose?.();

@sedson sedson merged commit e637222 into main Jan 12, 2026
22 checks passed
@sedson sedson deleted the seamus/fix-task-compose-close-bttn branch January 12, 2026 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants