feat(properties): add properties to soup queries.#952
Merged
Conversation
cowlicks
force-pushed
the
add-properties-to-soup
branch
2 times, most recently
from
ca1e76b to
4f58e41
Compare
whutchinson98
added
the
do-not-review
cowlicks
commented
Jan 14, 2026
cowlicks
commented
Jan 14, 2026
rust/cloud-storage/system_properties/src/domain/model/constants/system_property_key.rs
Show resolved
Hide resolved
cowlicks
commented
Jan 14, 2026
rust/cloud-storage/soup/src/outbound/pg_soup_repo/expanded/dynamic.rs
Outdated
Show resolved
Hide resolved
whutchinson98
removed
the
do-not-review
Contributor
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
cowlicks
force-pushed
the
add-properties-to-soup
branch
from
c95fcff to
451ff26
Compare
danielkweon
reviewed
Jan 19, 2026
danielkweon
force-pushed
the
add-properties-to-soup
branch
2 times, most recently
from
99ccf62 to
1af7fa0
Compare
don't fill up hashmap with all keys don't use duplicated entity type to select with
…etters - Revert behavioral changes from commit 4618763 - Keep &[Uuid] parameter improvement for property_ids - Keep unindented SQL string formatting - All requested entity_ids are now present in result (with empty vecs if no properties)
danielkweon
force-pushed
the
add-properties-to-soup
branch
from
ed4bce1 to
39f702a
Compare
synoet
changed the title
Contributor
|
taking this over the line. |
whutchinson98
approved these changes
Jan 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Screenshots, GIFs, and Videos