Conversation
Contributor
synoet
commented
Jan 13, 2026
- Removes the commplex caching logic we have setup
- Makes frontmatter of blocks use a tanstack query instead of calling service directly
- issues proper invalidations when updating a property from the frontmatter
sedson
approved these changes
Jan 13, 2026
dev-rb
reviewed
Jan 13, 2026
Contributor
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
Contributor
Code reviewI found debug console.log statements that should be removed before merging. Issue: Debug console.log statements in production codeTwo debug File:
Why this is an issue: According to CLAUDE.md#L20, the guideline mentions using Suggested fix: Remove both console.log statements: // Line 42 - Remove this line
function bulkIncludesEntityPredicate(queryKey: QueryKey, entityId: string) {
console.log(queryKey); // <-- Remove
return (
queryKey.includes('properties') &&
queryKey.includes('bulk') &&
queryKey.some(
(subKey) => Array.isArray(subKey) && subKey.includes(entityId)
)
);
}
// Line 59 - Remove this line
export function invalidatePropertiesForEntity(
entityType: EntityType,
entityId: string
) {
console.log('invalidate'); // <-- Remove
queryClient.invalidateQueries({
queryKey: propertiesKeys.entity({ entityType, entityId }).queryKey,
});
// ...
}Otherwise, the PR looks good! The migration to TanStack Query is well-structured and follows the codebase patterns. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.