Skip to content

feat: fix search highlight#956

Merged
gbirman merged 1 commit intomainfrom
gab/chore/fix-search-highlight-not-going-away
Jan 13, 2026
Merged

feat: fix search highlight#956
gbirman merged 1 commit intomainfrom
gab/chore/fix-search-highlight-not-going-away

Conversation

@gbirman
Copy link
Copy Markdown
Contributor

@gbirman gbirman commented Jan 13, 2026

Summary

Screenshots, GIFs, and Videos

@gbirman gbirman requested a review from a team as a code owner January 13, 2026 16:09
@github-actions
Copy link
Copy Markdown

@claude
Copy link
Copy Markdown
Contributor

claude bot commented Jan 13, 2026

Code review

Issue found: Missing tests for bug fix

This PR fixes a bug (search highlight) but does not include tests to verify the fix or prevent regression.

According to CLAUDE.md:

Testing - Write tests for your changes. When fixing bugs or regressions, identify the issue with a test before fixing it.

Location: js/app/packages/macro-entity/src/components/EntityWithEverything.tsx:773

The change adds isSearch() && to the condition, which fixes the search highlight logic. However, no tests were added to:

  1. Verify the bug is fixed (search highlight only appears when isSearch() is true)
  2. Prevent regression of this issue in the future

The macro-entity package currently has no test files. Consider adding a test file for EntityWithEverything.tsx that covers this search highlighting behavior.

@gbirman gbirman merged commit 2252738 into main Jan 13, 2026
23 checks passed
@gbirman gbirman deleted the gab/chore/fix-search-highlight-not-going-away branch January 13, 2026 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants