chore(soup): replace custom either with axum_extra either#975
Merged
Conversation
seanaye
force-pushed
the
seanaye/chore/axum-extra-either
branch
from
441b983 to
07789a2
Compare
Contributor
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
seanaye
force-pushed
the
seanaye/chore/axum-extra-either
branch
from
07789a2 to
d35aa7c
Compare
synoet
approved these changes
Jan 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
We had a custom Either impl for FromRequestParts, but it turns out theres one in axum_extra, so we use that instead and delete the custom one
Screenshots, GIFs, and Videos