fix: try cache first for mobile notifications

[peterchinman]

No description provided.

[github-actions]

Preview: https://peter-use-cache-1mq7qo.preview.macro.com/app (e5d8258)

[claude]

Code Review

I found one issue related to CLAUDE.md compliance:

Missing Tests for New Functionality

This PR adds a new exported function getNotificationFromCache() and modifies the behavior of openNotificationFromId() to check the cache first, but no tests are included.

According to CLAUDE.md, Development Notes #4 states:

Testing - Write tests for your changes. When fixing bugs or regressions, identify the issue with a test before fixing it.

Suggested Tests

The existing test file at user-notifications.test.tsx shows that this codebase has an established testing practice for functions in user-notifications.ts.

Consider adding tests for:

1. getNotificationFromCache():

   • Notification found in cache
   • Notification not found in cache (returns undefined)
   • Multiple pages in cache data
   • Invalid/undefined cache data

2. openNotificationFromId() cache-first behavior:

   • Opening a notification that exists in cache (should not make network request)
   • Opening a notification not in cache (should fall back to network request)
   • Handling when cached notification fails typing

---

Related files:

• notification-navigation.ts:201-210 - Cache-checking logic
• user-notifications.ts:365-386 - New getNotificationFromCache function