Update validator model #229
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p-ferreira
commented
May 13, 2024
Contributor
Author
|
@dbobrenko Unfortunately I cannot add you as a reviewer in this space but please consider yourself as a reviewer of all PRs of this repo (specially the ones with tag |
dbobrenko
reviewed
May 17, 2024
Collaborator
dbobrenko
left a comment
dbobrenko
left a comment
There was a problem hiding this comment.
Should we update min_compute.yaml also, and README.md?
Overall, LGTM!
dbobrenko
reviewed
May 17, 2024
Co-authored-by: Dmytro Bobrenko <17252809+dbobrenko@users.noreply.github.com>
Co-authored-by: Dmytro Bobrenko <17252809+dbobrenko@users.noreply.github.com>
bkb2135
approved these changes
May 17, 2024
Collaborator
bkb2135
left a comment
bkb2135
left a comment
There was a problem hiding this comment.
Looks good and has been run on main stabely.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--neuron.gpusand--neuron.llm_max_allowed_memory_in_gbnew parameters and integrationcasperhansen/llama-3-70b-instruct-awq