Skip to content

v2.18.3: Check for full completion, smooth chunk stream #683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Apr 22, 2025
Merged

v2.18.3: Check for full completion, smooth chunk stream #683

merged 14 commits into from
Apr 22, 2025

Conversation

@dbobrenko
Copy link
Collaborator

@dbobrenko dbobrenko commented Apr 21, 2025 •
edited
Loading

Changes

  • Check for full completion;
  • Add inference reward scale for streaming variance between chunks;
  • Scale inference reward with cosine similarity with grouth truth logits;
  • Add tests for inference;
  • Add deps required for asyncio tests;
  • Close all processes before exit.

@dbobrenko
Check eos, ensure smooth stream, add tests
5509e8e 
- Check eos for each completion;
- Add inference reward scale for streaming variance between chunks;
- Scale inference reward with cosine similarity with grouth truth logits;
- Add tests for inference;
- Add deps required for asyncio tests;
- Close all processes before exit.
@dbobrenko
Make error message more concise
567de84
@dbobrenko
Add new line
f615c09
@dbobrenko
Wrap process kill into try except
dd39aad
@dbobrenko
Update lock
034337d
@dbobrenko
Run pre-commit
03bd810
@dbobrenko dbobrenko changed the title Check for eos_token v2.18.3: Check for eos_token Apr 22, 2025
@dbobrenko dbobrenko changed the title v2.18.3: Check for eos_token v2.18.3: Check eos_token, smooth chunk stream Apr 22, 2025
@dbobrenko dbobrenko changed the title v2.18.3: Check eos_token, smooth chunk stream v2.18.3: Check for full completion, smooth chunk stream Apr 22, 2025
@dbobrenko dbobrenko merged commit 7564985 into main Apr 22, 2025
1 check passed
@dbobrenko dbobrenko deleted the fix/SN1-461 branch July 3, 2025 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bkb2135 bkb2135 bkb2135 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dbobrenko @bkb2135