Skip to content

Enhance logprobs checks #692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Apr 26, 2025
Merged

Enhance logprobs checks #692

merged 10 commits into from
Apr 26, 2025

Conversation

@dbobrenko
Copy link
Collaborator

@dbobrenko dbobrenko commented Apr 25, 2025 •
edited
Loading

Changes

  • Increase thresholds.
  • Improve eos checks.
  • Improve weighted cosine similarity for logprobs.
  • Fix bos_token before next token prediction.
  • Fix prompt modification before next token prediction.

@dbobrenko dbobrenko merged commit a3c0330 into main Apr 26, 2025
1 check passed
@dbobrenko dbobrenko deleted the fix/stricter-checks branch July 3, 2025 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bkb2135 bkb2135 bkb2135 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dbobrenko @bkb2135