Skip to content

Fix errors, remove hardcode, add error handling #763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 20, 2025
Merged

Fix errors, remove hardcode, add error handling #763

merged 5 commits into from
Jun 20, 2025

Conversation

@dbobrenko
Copy link
Collaborator

@dbobrenko dbobrenko commented Jun 20, 2025 •
edited
Loading

Changes

  • Fix Attribute error in InferenceTask.
  • Get tokenizer per model id.
  • Add error handling during logprobs check.
  • Remove spam of log files.
  • Add support for deprecated max_new_tokens.
  • Fix file name style violation.
  • Bump version.

@dbobrenko dbobrenko merged commit 722ffc9 into staging Jun 20, 2025
1 check passed
@dbobrenko dbobrenko mentioned this pull request Jun 20, 2025
Merged
@dbobrenko dbobrenko deleted the feature/SN1-522 branch July 3, 2025 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bkb2135 bkb2135 bkb2135 approved these changes

+1 more reviewer

@richwardle richwardle richwardle approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dbobrenko @richwardle @bkb2135