macvim-snapshot-171 won't compile on macOS 11.2.3

[matbess]

Installation of the latest macvim via homebrew fails on make with the follow error:

Error Details

==> Installing macvim
==> ./configure --with-features=huge --enable-multibyte --enable-perlinterp --enable-rubyinterp --enable-tclinterp --enable-terminal --with-tlib=ncurse
==> make
Last 15 lines from /Users/mat/Library/Logs/Homebrew/macvim/02.make:
)
libc++abi.dylib: terminating with uncaught exception of type NSException
Command CompileAssetCatalog failed with a nonzero exit code

warning: The macOS deployment target 'MACOSX_DEPLOYMENT_TARGET' is set to 11.2, but the range of supported deployment target versions is 10.9 to 11.1.99. (in target 'MacVim' from project 'MacVim')
warning: The macOS deployment target 'MACOSX_DEPLOYMENT_TARGET' is set to 11.2, but the range of supported deployment target versions is 10.9 to 11.1.99. (in target 'QuickLookStephen' from project 'QuickLookStephen')
warning: Traditional headermap style is no longer supported; please migrate to using separate headermaps and set 'ALWAYS_SEARCH_USER_PATHS' to NO. (in target 'QuickLookStephen' from project 'QuickLookStephen')
** BUILD FAILED **


The following build commands failed:
	CompileAssetCatalog /tmp/macvim-20210409-40465-1jcssxp/macvim-snapshot-171/src/MacVim/build/Release/PSMTabBarControl.framework/Versions/A/Resources /tmp/macvim-20210409-40465-1jcssxp/macvim-snapshot-171/src/MacVim/PSMTabBarControl/Media.xcassets
(1 failure)
make[1]: *** [macvim] Error 65
make: *** [first] Error 2

Do not report this issue to Homebrew/brew or Homebrew/core!

Environment

• $ vim --version
  VIM - Vi IMproved 8.2 (2019 Dec 12, compiled Dec 21 2020 20:40:08)
  macOS version
  Included patches: 1-850, 1972
  Compiled by root@apple.com
• OS: macOS 11.2.3
• Terminal: macOS terminal

[eirnym]

Thank you for an issue

Could you try prebuilt version from GitHub?

[matbess]

Thank you for an issue

Could you try prebuilt version from GitHub?

The prebuilt version works

[eirnym]

I'd say formula should change ABI to the latest available on a system, but I don't know if it would work if xcodeproject/workspace would change

[ychin]

@matbess what's the command you used to install MacVim on Homebrew? Did you just pass the -s flag?

[matbess]

@ychin just brew install macvim

Do you want all of the output from the terminal?

[ychin]

I think the question I have is why you are building macvim from source when using Homebrew. By default it should try to grab the prebuilt bottle and just install that without building. Do you have some special settings? If not, I'm curious to see the output.

[matbess]

Good question. It looks like there is both a formula and cask and I didn't notice this message when I tried to install with brew install macvim:

Warning: Treating macvim as a formula. For the cask, use homebrew/cask/macvim
Warning: Building macvim from source as the bottle needs:

Installing with brew --cask install macvim caused it to use the prebuilt bottle.

[ychin]

Hold on a second. Cask is a completely separate thing and wasn't what I was talking about here. I was talking about bottles which are pre-built formulas. Your log was talking about the bottle needing some requirements in the following lines but I think you omitted those lines. The lack of said requirements is causing you to build locally. Still a bug that you can't build locally though. I think this is probably a Homebrew bug tbh, since MacVim builds fine if you grab it from GitHub.

[ychin]

Anyway do you mind listing what the log showed after those lines? It may explain why you are not getting the prebuilt bottles. (When you use Homebrew Cask you are basically downloading from the GitHub releases)

I can look into why it's not building locally when building from source.

[matbess]

Ah ok, I see what you're saying. Looks like the bottle doesn't like my homebrew prefix:

Warning: Treating macvim as a formula. For the cask, use homebrew/cask/macvim
Warning: Building macvim from source as the bottle needs:
- HOMEBREW_CELLAR: /usr/local/Cellar (yours is /usr/local/homebrew/Cellar)
- HOMEBREW_PREFIX: /usr/local (yours is /usr/local/homebrew)

Also, I haven't tried building macvim from source off of github (if you were implying that I had, unless you meant that you have done it).

[matbess]

I'm re-reading the instructions at https://docs.brew.sh/Installation and I believe I may have ended up setting my prefix incorrectly because the instructions are confusing and I ran the installation command inside of /usr/local.. but I'm guessing that (based on the error message) this ends up giving me the wrong prefix on intel mac.

mkdir homebrew && curl -L https://github.com/Homebrew/brew/tarball/master | tar xz --strip 1 -C homebrew

So, it may just be a bad homebrew installation.

[ychin]

Oh interesting. That's probably why. Homebrew usually prefers you use the default installation locations.