Fix configure not working with custom grep#1024
Merged
ychin merged 1 commit intomacvim-dev:masterfrom Mar 15, 2020
Merged
Conversation
5e199f4 added a check to make sure configure is properly parsing the Vim version string, but it doesn't work if user has installed GNU grep instead of the system one. Fix it to use the more common `[[:digit:]]` (instead of `\d`), and also hardcode the path for grep. Fix macvim-dev#1017
ychin
force-pushed
the
fix-configure-custom-grep
branch
from
4094079 to
dfb955c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
5e199f4 added a check to make sure configure is properly parsing the Vim version string, but it doesn't work if user has installed GNU grep instead of the system one. Fix it to use the more common
[[:digit:]](instead of\d), and also hardcode the path for grep.Fix #1017