Code clean up / robustification and additional logging for render #1173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clean up code per clang analyzer. Make sure to initialize structs properly and clean up potential memory leaks. When drawing wide characters, clean up the other cell to be empty just to be clean. When updating fonts for a MacVim window, if it's not the main window, make sure to not update the shared font manager as it's previously a minor bug where it would do that. Add additional debug logging for renderer to help debug potential CoreText renderer issues. See macvim-dev#1164.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clean up code per clang analyzer. Make sure to initialize structs properly and clean up potential memory leaks.
When drawing wide characters, clean up the other cell to be empty just to be clean.
When updating fonts for a MacVim window, if it's not the main window, make sure to not update the shared font manager as it's previously a minor bug where it would do that.
Add additional debug logging for renderer to help debug potential CoreText renderer issues. See #1164.