Fix broken preference pane sizing when sparkle disabled #1282
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The recent change that added smooth resizing changed the alignment for the General preference pane from bottom to top aligned as it never made sense to be bottom aligned. However, there was code in in the preference controller to correct for that when resizing the pane when sparkle is disabled, which caused the resizing to not work. Fix that to account for the top alignment instead of bottom. Fix macvim-dev#1281
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recent change that added smooth resizing changed the alignment for the General preference pane from bottom to top aligned as it never made sense to be bottom aligned. However, there was code in in the preference controller to correct for that when resizing the pane when sparkle is disabled, which caused the resizing to not work. Fix that to account for the top alignment instead of bottom.
Fix #1281