ci: Fix test_popup failing on macos-13 due to lack of italics support #1609
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ychin
added
Infrastructure
Up till macOS 13, the default terminal does not properly advertise it supports italics, and Vim just silently replaces it with the "reverse" effect. Revently, a test in test_popup (Test_popup_shadow_hiddenchar) was added and the test dumps assume italics support. Add checks to skip this test if we detect that italics is not supported to avoid failing the screen dump tests. Note that macos-13 is being sunset by GitHub Actions, but we still use a self-hosted version of it to make legacy builds. Note that due to MacVim silently passing all flaky tests currently, this test wasn't breaking CI anyway, but it did slow it down due to test retries, and we do want to go back to not silently passing flaky tests in near future.
ychin
force-pushed
the
fix-test-popup-italics-macos-13
branch
from
2d674d0 to
0b0f598
Compare
ychin
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Up till macOS 13, the default terminal does not properly advertise it supports italics, and Vim just silently replaces it with the "reverse" effect. Revently, a test in test_popup (Test_popup_shadow_hiddenchar) was added and the test dumps assume italics support. Add checks to skip this test if we detect that italics is not supported to avoid failing the screen dump tests.
Note that macos-13 is being sunset by GitHub Actions, but we still use a self-hosted version of it to make legacy builds.
Note that due to MacVim silently passing all flaky tests currently, this test wasn't breaking CI anyway, but it did slow it down due to test retries, and we do want to go back to not silently passing flaky tests in near future.