Skip to content

ci: Fix test_popup failing on macos-13 due to lack of italics support #1609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 30, 2025
Merged

ci: Fix test_popup failing on macos-13 due to lack of italics support #1609

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions src/testdir/test_popup.vim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2396,6 +2396,15 @@ endfunc
func Test_popup_shadow_hiddenchar()
CheckScreendump

if has('osx')
" On older macOS versions, the default Terminal app does not properly
" advertise italics support, which this test requires. When that happens,
" Vim just uses t_mr (reverse) as a substitute, which we detect here.
if &t_ZH == &t_mr
throw 'Skipped: italics not supported'
endif
endif

let lines =<< trim END
bold italic underline reverse normal
italic underline reverse normal bold
Expand Down