Fix additional deprecation warnings.#38
Merged
douglaskayama merged 3 commits intomacvim-dev:masterfrom Jul 6, 2015
jpetrie:fix-warnings
Merged
Fix additional deprecation warnings.#38douglaskayama merged 3 commits intomacvim-dev:masterfrom jpetrie:fix-warnings
douglaskayama merged 3 commits intomacvim-dev:masterfrom
jpetrie:fix-warnings
Conversation
Contributor
|
As long as this doesn't break building on Tiger... |
Contributor
Author
|
I don't think it will - I left the old calls in place in the negative branches of the availability macro branches. I don't have any way to test building on Tiger, though, so it's possible I've made a mistake. EDIT: I did make a mistake, as you discovered with issue #40. I am pretty sure I know how to fix it though. |
- added availability macro constants for OS X versions through 10.10.3 so compilation on earlier OS versions still works. - added a versioning guard to a NSScroller change that slipped by unnoticed in a previous commit.
douglaskayama
added a commit
that referenced
this pull request
Jul 6, 2015
Fix additional deprecation warnings.
splhack
pushed a commit
that referenced
this pull request
Oct 15, 2015
Problem: C indenting is wrong below a "case (foo):" because it is
recognized as a C++ base class construct. Issue #38.
Solution: Check for the case keyword.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change address two more classes of warnings found in the Xcode project:
[NSScroller scrollerWidth]was deprecated in 10.7; the modern equivalent is[NSScroller scrollerWidthForControlSize]; the method is only invoked once per function now, as well, as a way to handle the availability macro guards more cleanly.