Fix artifacts when entering full screen. #487
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes MMFullScreenWindow to release the fade in a completion handler for the current transaction, so that the app flushes updates while the screen is black. It also fixes up the fadeReservationTime math and bumps the slack to a full second so that a slightly slow draw doesn't cause artifacts (in practice, the fade will be released as soon as the window draws — the reservation time is just a failsafe).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Take a look!
This changes
MMFullScreenWindowto release the fade in a completion handler for the current transaction, so that the app flushes updates while the screen is black. It also fixes up thefadeReservationTimemath and bumps the slack to a full second so that a slightly slow draw doesn't cause artifacts (in practice, the fade will be released as soon as the window draws — the reservation time is just a failsafe).