Skip to content

Fix version-check code#659

Merged
splhack merged 1 commit intomacvim-dev:masterfrom
ichizok:fix/version-check
Mar 27, 2018
Merged

Fix version-check code#659
splhack merged 1 commit intomacvim-dev:masterfrom
ichizok:fix/version-check

Conversation

@ichizok
Copy link
Copy Markdown
Member

@ichizok ichizok commented Mar 26, 2018

In .travis.yml MACOSX_DEPLOYMENT_TARGET=10.8 is set, thus, on Travis CI, version-check code is skipped and the issues #620 #632 have recurred in released MacVim.

macro condition depends on MACOSX_DEPLOYMENT_TARGET variable
@splhack splhack merged commit 3b3b6b3 into macvim-dev:master Mar 27, 2018
@ichizok ichizok deleted the fix/version-check branch March 27, 2018 01:57
@ichizok
Copy link
Copy Markdown
Member Author

ichizok commented Mar 27, 2018

@splhack Sorry, could you revert this commit?
When build env is older than 10.10, NSOperatingSystemVersion does not exist so (I have not confirmed but) it will causes build fail.

@splhack
Copy link
Copy Markdown
Contributor

splhack commented Mar 27, 2018

sure. done

@ichizok
Copy link
Copy Markdown
Member Author

ichizok commented Mar 27, 2018

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants