Skip to content

Fix fetchGlyphsAndAdvances() in CoreText renderer#700

Merged
splhack merged 1 commit intomacvim-dev:masterfrom
ichizok:fix/fetch-glyphs
Jun 26, 2018
Merged

Fix fetchGlyphsAndAdvances() in CoreText renderer#700
splhack merged 1 commit intomacvim-dev:masterfrom
ichizok:fix/fetch-glyphs

Conversation

@ichizok
Copy link
Copy Markdown
Member

@ichizok ichizok commented Jun 25, 2018

This will fix #693

In fetchGlyphsAndAdvances() when count < offset, count is signed and offset is unsigned so count - offset is a huge value then count - offset > length is true and count becomes a wrong value (count = length - offset).
Thus CTRungetGlyphs() will fail.

I think it is the correct way to check if count > length - offset.

@splhack splhack merged commit 6ff781f into macvim-dev:master Jun 26, 2018
@ichizok ichizok deleted the fix/fetch-glyphs branch June 26, 2018 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Wrong rendering of some chars

2 participants