Conversation
| - echo -en "travis_fold:end:build\\r\\033[0K" | ||
| - set +o errexit | ||
| - echo -e "\\033[33;1mTesting MacVim\\033[0m" && echo -en "travis_fold:start:test\\r\\033[0K" | ||
| - macvim_excmd() { ${VIMCMD} -u NONE -i NONE -g -f -X -V1 -es "$@" -c 'echo ""' -c quit 2>&1; } |
There was a problem hiding this comment.
Why remove the redit>result and grep in the end?
There was a problem hiding this comment.
I think these one-line tests should check whether each of if_xxx commands work properly or not (minimal test), and output should be tested in make test.
|
Let me think about this a little bit. I'm a little hesitant because I find Travis CI to have too long of a turnaround time these days (30+ minutes) and a small issue can drag on forever and slow down iteration. While exposing more errors is good, I find that halting immediately tend to give a fast feedback to the user and when you scroll down to the end of the log that's where the error is instead of needing to scroll up the massive amount of log spam from successful tests and search around. |
ichizok
force-pushed
the
fix/travis
branch
3 times, most recently
from
b80dec6 to
ea2b861
Compare
|
Hi @ichizok is this still work in progress? I noticed you renamed the title to "[WIP]" a while ago but wondering if there are still changes that need to go in. |
|
There are the below major factors causing tests take long time:
|
ichizok
force-pushed
the
fix/travis
branch
3 times, most recently
from
b3670e2 to
fc12bc7
Compare
ichizok
force-pushed
the
fix/travis
branch
2 times, most recently
from
2608020 to
2a33383
Compare
ichizok
force-pushed
the
fix/travis
branch
2 times, most recently
from
b0016ca to
0950838
Compare
* Cache Homebrew taps * Colorize stage messages * Simplify if_xxx tests * Improve if_ruby build config * Make build stages to separate build and deploy jobs
Doing 'set fullscreen' and 'set nofullscreen' at once doesn't work properly: the values of "&lines" and "&columns" are restored, but the fullscreen is kept on actually and thus affects 'writedelay' test performance.
|
Hi @ichizok sorry for the delay in merging this but the change looks good and thanks a lot for doing this. It cuts down on the build times a lot. Since you have been working on this branch for a while just giving you some time to respond if there are more things you want to push to it before I hit merge. |
|
Thank you, please merge. |
2 participants
I think should do all tests in order to expose all existing problems except when configure/build fail.