Remove setting default pythonhome and pythonthreehome#891
Merged
ychin merged 1 commit intomacvim-dev:masterfrom May 14, 2019
Merged
Remove setting default pythonhome and pythonthreehome#891ychin merged 1 commit intomacvim-dev:masterfrom
ychin merged 1 commit intomacvim-dev:masterfrom
Conversation
It's enough to set pythondll/pythonthreedll if you want defaults
Member
|
I looked and I don't see anything MacVim is doing that is specific to python home, so your change should be good. Thanks for the change. I do think the MacVim-provided vimrc should set as little as possible to avoid stomping user settings so in this case I think this is a good change, especially given that it's fixed in Vim per your link. If users care enough about setting their python home, they can do that, but we shouldn't impose that on them when the default case of leaving pythonhome unset works most of the time. |
Member
|
Just tagging #760 for backlinking as that's the main issue tracking Python compat issues. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's enough to set pythondll/pythonthreedll if you want defaults as per vim/vim@0424958. Before it was a requirement to set both.
Probably, closes #562 forever.
@ychin please verify if compile flags doesn't specify pythonhome/pythonthreehome explicitly