Add missing message ID string, then refactor to make that harder to repeat#893
Merged
ychin merged 1 commit intomacvim-dev:masterfrom May 18, 2019
Merged
Conversation
Contributor
|
Looks good for me |
Member
|
Great catch! I imagine it must have been annoying with the debugging messages. @s4y, can you do the following before I will merge:
|
s4y
changed the title
s4y
force-pushed
the
missing-message-string
branch
from
063e870 to
239548c
Compare
Contributor
Author
|
Sure thing!
|
One type (`UseSelectionForFindMsgID`) was missing from `MessageStrings`, which made the following strings out of sync with their IDs. This change uses a macro to generate both, so they'll stay in sync, and renames `MessageStrings` to `MMVimMsgIDStrings` to be more specific.
s4y
force-pushed
the
missing-message-string
branch
from
239548c to
3caccbb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains a few commits:
"UseSelectionForFindMsgID"toMessageStrings: it was missing and the following strings were out of sync with the enum.MessageStrings, to stop them from getting out of sync again. I don't have strong feelings about the details of how that's done; feel free to change it or suggest changes!MessageStringstoMMVimMsgIDStrings, and makes it const, for clarity.