-[MMCoreTextView initWithFrame:] doesn't initialize fontDescent #927
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
LGTM |
Contributor
Author
|
PR updated according to comment. |
Member
|
Alright looks good. Thanks for the fix. |
ychin
added a commit
to ychin/macvim
that referenced
this pull request
Oct 16, 2019
Recent fix to font initialization (macvim-dev#927) seems to have caused issues with other fonts. Keep the fix but revert to the old way of font initialization by manually creating a new one with point size to not use the other aspects of the font to keep the behavior consistent with previous behavior Fix macvim-dev#928
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #883. Makes sure
fontDescentis properly initialized by-[MMCoreTextView initWithFrame:].