Merged
Conversation
Two changes: 1. Switch PSMTabBarCell from accessing NSCell's _controlView ivar, which is gone, to accessing its controlView property. Also override the controlView property to be a PSMTabBarControl instead of an NSView. 2. Move macvim-askpass from MacOS to Resources to not confuse codesign. Fixes macvim-dev#936.
Contributor
|
Thank you for your PR. From my side, I ask only to check where |
Contributor
Author
|
@eirnym: Could you say more? The |
eirnym
approved these changes
Oct 3, 2019
Contributor
|
@s4y I don't know how exactly older Xcode versions read this setting. Some people here prefer to keep some compatibility with older systems just because they use them. I don't know how old systems are and which Xcode versions are good to test. Otherwise, I'm fine with your changes. |
Contributor
Author
|
@eirnym Got it; sure. I just went through the Travis build logs for Xcode 7, 8, 9, and 10, which show Travis logsxcode7.3xcode8.3xcode9.4xcode10.2 |
Contributor
|
Thank you |
|
The PR works great for me. |
Member
|
Thanks for doing this. I double checked in older Xcode versions and the folder seemed fine. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See commit message for details.