Revert "Enable hardened runtime"#966
Merged
ychin merged 1 commit intomacvim-dev:masterfrom Oct 22, 2019
Merged
Conversation
The hardened runtime was causing issues with misc unsigned frameworks and failing CI, and also making it hard to locally debug code. Because we currently perform code signing outside of Xcode anyway by using the `codesign` utility, it's not particularly useful to embed hardened runtime in the project file itself. We just need to sign the app with `-o runtime` flag when signing it before sending over to notarization service. This reverts commit 76cb94b.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The hardened runtime was causing issues with misc unsigned frameworks and failing CI, and also making it hard to locally debug code. Because we currently perform code signing outside of Xcode anyway by using the
codesignutility, it's not particularly useful to embed hardened runtime in the project file itself. We just need to sign the app with-o runtimeflag when signing it before sending over to notarization service.This reverts commit 76cb94b.