Skip to content

Expose --window or --no-window args#123

Merged
marciniwanicki merged 1 commit into
macvmio:mainfrom
beefon:dev/beefon/WindowArg
Nov 2, 2024
Merged

Expose --window or --no-window args#123
marciniwanicki merged 1 commit into
macvmio:mainfrom
beefon:dev/beefon/WindowArg

Conversation

@beefon
Copy link
Copy Markdown
Contributor

@beefon beefon commented Nov 2, 2024

I just thought it would be nice to use the argparser's feature of value inversion using --no prefix which seems to be common thing among CLI tools.

./.build/debug/curie run -h                        
OVERVIEW: Start an ephemeral container.

USAGE: curie run <reference> [--window] [--no-window] [--recovery-mode] [--share-cwd] [--main-screen-resolution] [--quiet]

OPTIONS:
  --window/--no-window    Create window or not. (default: --window)
..
..
..

Copy link
Copy Markdown
Contributor

@marciniwanicki marciniwanicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @beefon, the changes look good.

@marciniwanicki marciniwanicki merged commit 5b632e6 into macvmio:main Nov 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants