socket synthesize-keyboard#156
Merged
Merged
Conversation
marciniwanicki
approved these changes
Feb 21, 2026
Contributor
marciniwanicki
left a comment
marciniwanicki
left a comment
There was a problem hiding this comment.
Thanks @beefon, the keyboard interaction works very well. Happy to rename the command to "keyboard" to make it shorter.
| import Foundation | ||
|
|
||
| public struct KeyboardInput: Codable { | ||
| public static let defaultdelayAfterStrokes = 0.1 |
Contributor
There was a problem hiding this comment.
Let's rename to defaultDelayAfterStrokes
| // limitations under the License. | ||
| // | ||
|
|
||
| /// Human-friendly variants of various keys, mostly to make JSON user firendly. |
Contributor
There was a problem hiding this comment.
"firendly" to "friendly"
| @@ -0,0 +1,53 @@ | |||
| // | |||
| // Copyright 2024 Marcin Iwanicki, Tomasz Jarosik, and contributors | |||
| """.trimmingCharacters(in: .whitespacesAndNewlines)) | ||
| } | ||
|
|
||
| func testKeyboardInput_KeyContent_NoModifiers() throws { |
Contributor
There was a problem hiding this comment.
It seems the test has "command" modifier so the name might be misleading.
| @@ -0,0 +1,148 @@ | |||
| // Copyright 2026 Marcin Iwanicki, Tomasz Jarosik, and contributors | |||
Contributor
There was a problem hiding this comment.
Missing // (for consistency)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements keyboard synthesis. The proposal:
Synthesised events are key presses of US ANSII keyboard. So actual result depends on the currently selected language in the target OS.