Skip to content

fix: istio-sidecar annotations #256

@mglotov

Description

@mglotov

Prerequisites

Please answer the following questions for yourself before submitting an issue. YOU MAY DELETE THE PREREQUISITES SECTION.

  • I am running the latest version
  • I checked the documentation and found no answer
  • I checked to make sure that this issue has not already been filed

Expected Behavior

Cluster Autoscaler doesn't touch pods not managed by any of controllers (deployment, replicaset, etc).

Current Behavior

All pods in a cluster (if Istio is installed) have annotation cluster-autoscaler.kubernetes.io/safe-to-evict: true. It allows Cluster Autoscaler to terminate such pods to reschedule them on other nodes.

The configuration

sidecarInjectorWebhook:
was added because of kubeflow/pipelines#4530. However, a new configuration of Cluster Autoscaler covers this case (
skip-nodes-with-local-storage: false
)

Failure Information (for bugs)

For example, if pods are run by Airflow they aren't managed by any controllers (raw pods) and Cluster Autoscaler can terminate such pods without waiting for finishing jobs (in case of scale-down nodes because of underutilization).

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions