Skip to content

fix: delete unnecessary istio-sidecar configuration #257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 23, 2022
Merged

fix: delete unnecessary istio-sidecar configuration #257

merged 1 commit into from
Feb 23, 2022

Conversation

@mglotov
Copy link
Contributor

@mglotov mglotov commented Feb 23, 2022

PR Description

Fixed cases when Cluster Autoscaler terminates pods aren't managed by any of the k8s controllers to downscale ASG.

Fixes #256

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 23, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@mglotov mglotov requested a review from a team February 23, 2022 04:27
@mglotov mglotov merged commit 1bd1e07 into main Feb 23, 2022
@mglotov mglotov deleted the istio-sidecar-annotations branch February 23, 2022 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@halfb00t halfb00t halfb00t approved these changes

@khalezin khalezin khalezin approved these changes

@p1gmale0n p1gmale0n Awaiting requested review from p1gmale0n

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

fix: istio-sidecar annotations

4 participants

@mglotov @halfb00t @khalezin