Skip to content

enh: use flags to enabled/disable additional functionalities instead of using examples folder #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Nov 15, 2021
Merged

enh: use flags to enabled/disable additional functionalities instead of using examples folder #176

merged 7 commits into from
Nov 15, 2021

Conversation

@mglotov
Copy link
Contributor

@mglotov mglotov commented Nov 10, 2021 •
edited
Loading

PR Description

  • Сhanged the way of using additional functionalities. Moved all of them in layer root folders and added a flag (count) to have the possibility to enable/disable them instead of having the examples folders
  • Introduced new k8s storageclass (advanced) and switched PVC to use it
  • Disabled metricbeat and apm server in default ELK installation. Deleted OAuth configuration for Kibana
  • Set resources:requests and limits for pilot (istio component)
  • Pinned security_group terraform module in modules/aws-ec2-pritunl and fixed issues with variables
  • Fixed networkpolicy for kube-prometheus-stack-operator (there was a problem with admission-webhook)
  • Restrict IAM permissions for Teamcity IAM policy

Fixes #172
Fixes #178
Fixes #179
Fixes #180
Fixes #181
Fixes #182
Fixes #183

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

@mglotov mglotov marked this pull request as ready for review November 12, 2021 08:57
@mglotov mglotov requested review from a team, halfb00t, khalezin and p1gmale0n and removed request for halfb00t and khalezin November 12, 2021 08:57
@mglotov mglotov marked this pull request as draft November 12, 2021 09:20
@mglotov mglotov marked this pull request as ready for review November 15, 2021 05:51
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 15, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@mglotov mglotov merged commit f1a56e1 into main Nov 15, 2021
@mglotov mglotov deleted the feature/introduce_flags_instead_of_examples_folder branch November 15, 2021 06:14
@mglotov mglotov mentioned this pull request Nov 15, 2021
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@halfb00t halfb00t halfb00t approved these changes

@khalezin khalezin khalezin approved these changes

+1 more reviewer

@p1gmale0n p1gmale0n p1gmale0n approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

5 participants

@mglotov @p1gmale0n @halfb00t @khalezin