Skip to content

feat: moved bottlerocket to managed node groups #228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 29, 2021
Merged

feat: moved bottlerocket to managed node groups #228

merged 4 commits into from
Nov 29, 2021

Conversation

@halfb00t
Copy link
Member

@halfb00t halfb00t commented Nov 26, 2021 •
edited
Loading

PR Description

  • Added managed node group for bottlerocket
  • Removed worker group for bottlerocket
  • Updated Readme.md

Fixes #227

Type of change

  • New feature (non-breaking change which adds functionality)
  • Documentation update

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

@halfb00t halfb00t requested review from a team, khalezin, mglotov and p1gmale0n November 26, 2021 09:28
@halfb00t halfb00t enabled auto-merge (squash) November 26, 2021 09:29
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 29, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@halfb00t halfb00t merged commit 19142eb into main Nov 29, 2021
@halfb00t halfb00t deleted the feat/bottlerocket branch November 29, 2021 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mglotov mglotov mglotov approved these changes

@khalezin khalezin Awaiting requested review from khalezin

+1 more reviewer

@p1gmale0n p1gmale0n p1gmale0n approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

feat: move bottlerocket form worker groups to managed node groups

4 participants

@halfb00t @p1gmale0n @mglotov