Skip to content

bug: fix gitlab-runner configuration #265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 12, 2022
Merged

bug: fix gitlab-runner configuration #265

merged 2 commits into from
Apr 12, 2022

Conversation

@mglotov
Copy link
Contributor

@mglotov mglotov commented Apr 11, 2022 •
edited
Loading

PR Description

  • Updated gitlab-runner helm chart to the latest version
  • Moved all deprecated options under config value
  • Updated default image of gitlab-runner-executor. Changed docker registry from Docker Hub to ECR Public registry
  • Fixed problems with certificates
  • Gitlab-runner can't deploy in any namespaces. There is an instruction

Fixes #258

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Documentation update

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 11, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@mglotov mglotov requested review from a team, halfb00t, khalezin and p1gmale0n April 11, 2022 08:41
@mglotov mglotov merged commit daf2495 into main Apr 12, 2022
@mglotov mglotov deleted the bug-gitlab-runner branch April 12, 2022 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@halfb00t halfb00t halfb00t approved these changes

@khalezin khalezin khalezin approved these changes

+1 more reviewer

@p1gmale0n p1gmale0n p1gmale0n approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

bug: Gitlab runner doesn't work with current configuration

5 participants

@mglotov @p1gmale0n @halfb00t @khalezin