Conversation
c42f209 to
a6be7b5
Compare
|
@madebr Could you please have a look? |
9a81bee to
ca42950
Compare
Signed-off-by: romintomasetti <romin.tomasetti@gmail.com>
madebr
left a comment
There was a problem hiding this comment.
Everything looks super! Thank you very much!
What kind of speed-up are you talking about with a project using cmake-file-api?
|
I haven't made any measurement but I expect that: will benefit. We use |
|
@madebr If you make a release, we'll be able to test if it behaves well in https://www.github.com/uliegecsm/reprospect 😉 |
I think the current release process is not correct and should be changed: it's failing. What do you suggest to do? |
This is a followup for madebr#29.
|
I think it is fine to have many wheels. It will be handled nicely if I remember well... I suggest to install the dev requirements, see #32 😉 |
Haha, yes, that's a requirement I was missing :) |
|
My understanding is that you are not breaking anything because it will also produce the source-based wheel that will be uploaded alongside any mypyc-based wheel on PyPi. And See for instance https://pypi.org/project/reprospect/#files. Along with the sources, there are different compiled versions. |
The goal of this PR is to add
mypycto speedup things "for free".I had to change a bit the
CMakeApiTypeprotocol becausemypycdoes not like class variables in adataclass: