Skip to content

Add SASS support#32

Closed
PavelDemyanenko wants to merge 1 commit intomadebysource:masterfrom
PavelDemyanenko:sass-support
Closed

Add SASS support#32
PavelDemyanenko wants to merge 1 commit intomadebysource:masterfrom
PavelDemyanenko:sass-support

Conversation

@PavelDemyanenko
Copy link

Hi. Tried to add SASS support (changes in generator: madebysource/generator-pho#6). I have some issue and can't figure out what's going wrong. When i run gulp task it goes just fine but files just don't compile. Also i have problems with configuration file, i moved main style and styles options to index which i guess is unacceptable. Would really appreciate your comments.
Best regards,
Pavel

@PavelDemyanenko PavelDemyanenko changed the title Add sass support. Add SASS support .. May 31, 2014
@PavelDemyanenko PavelDemyanenko changed the title Add SASS support .. Add SASS support May 31, 2014
@PavelGavlik
Copy link
Collaborator

Hi Pavel,
thanks for the PR. I got it working when I replaced gulp-ruby-sass with gulp-sass and changed following code in index.js.

config.src.styleMain = 'main.
config.src.styleFiles = '**/*.scss';
var cssPreprocessor = $.sass(config.sass);

File extensions were incorrect and rubySass doesn't work for some unknown reason.

However, as you said, it's not very good solution when part of config file has to be in index.js. I'd like to implement Sass support purely in generator-pho. It should be possible by replacing styles task or adding a new task in indexDependencies. This way pho-devstack won't have both Less and Sass as an dependency. pho-devstack package is quite monolithic now, I plan to have more modular code as 2.0.

You can use fix above if you want Sass support now. I'll implement the mentioned solution next week. Or you can do it, that would be great :-)

@PavelDemyanenko
Copy link
Author

Thank you very much! That is a very good idea having css options in generator but not in devstack.
If i succeed in implementing mentioned solution i'll let you know :)
Best regards,
Pavel

@jb510 jb510 mentioned this pull request Jun 4, 2014
@JHKennedy4
Copy link

Hey what the status of this PR? How can I help? I love the premise of this stack, but I'd like to see sass support. I'd be happy to tackle whatever needs to be done.

@PavelGavlik
Copy link
Collaborator

Hi, Sass support is first item on my todo list. I hope I will tackle it this Sunday. I will let you know if I encounter some problems.

On 7. 6. 2014, at 18:50, John Kennedy notifications@github.com wrote:

Hey what the status of this PR? How can I help? I love the premise of this stack, but I'd like to see sass support. I'd be happy to tackle whatever needs to be done.


Reply to this email directly or view it on GitHub.

@JHKennedy4
Copy link

Great to hear. Please feel free to reach out any time if you need a second
set of eyes or want to delegate something.
On Jun 7, 2014 12:58 PM, "Pavel Gavlík" notifications@github.com wrote:

Hi, Sass support is first item on my todo list. I hope I will tackle it
this Sunday. I will let you know if I encounter some problems.

On 7. 6. 2014, at 18:50, John Kennedy notifications@github.com wrote:

Hey what the status of this PR? How can I help? I love the premise of
this stack, but I'd like to see sass support. I'd be happy to tackle
whatever needs to be done.


Reply to this email directly or view it on GitHub.


Reply to this email directly or view it on GitHub
#32 (comment)
.

@PavelGavlik
Copy link
Collaborator

Closing this one (Sass support added). Moving discussion back to #19

@PavelGavlik PavelGavlik closed this Jun 9, 2014
@PavelDemyanenko PavelDemyanenko deleted the sass-support branch October 2, 2014 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants