Fix token sampling underflow for short token datasets#17
Merged
maderix merged 1 commit intomaderix:mainfrom Mar 4, 2026
Merged
Conversation
dev-erik
added a commit
to dev-erik/ANE
that referenced
this pull request
Mar 3, 2026
…size_t wraparound on short datasets in both train_large variants
Owner
|
Thanks for catching this — clean fix for a real underflow bug. Merged! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mmapintrain_large.msize_tunderflow inmax_pos = n_tokens - SEQ - 1Why
max_posis computed from unsignedsize_t. Ifn_tokens <= SEQ + 1, the subtraction wraps to a huge value, which can produce invalid random offsets and out-of-bounds reads.Validation
make train_largeintraining/