Skip to content

Conversation

@yoori
Copy link
Contributor

@yoori yoori commented Apr 8, 2025

…ubdirectory in other project

Hi, great work ! Thank you !
Here is trivial changes, that allow to build your project inside other project source tree as git submodule + add_subdirectory ( without cmake FetchContent)

@madf
Copy link
Owner

madf commented Apr 9, 2025

Should PROJECT_SOURCE_DIR do the same thing?

@yoori
Copy link
Contributor Author

yoori commented Apr 10, 2025

You right, we can use it and this is more consistent - I will change pull request

@madf
Copy link
Owner

madf commented Apr 10, 2025

Ok. I'm waiting for the changes.

@yoori
Copy link
Contributor Author

yoori commented Apr 10, 2025

Done

@madf madf merged commit ee31882 into madf:main Apr 11, 2025
@madf
Copy link
Owner

madf commented Apr 11, 2025

Merged. Thanks for contribution! I'll make a new release soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants