Move default fptype to m in cudacpp makefiles and scripts by valassi · Pull Request #1017 · madgraph5/madgraph4gpu

valassi · 2024-10-06T06:15:05Z

This is a small PR to move default fptype to m in cudacpp makefiles and scripts

It fixes #995

…m 'd' to 'm' (madgraph5#995), to be consistent with cudacpp_backend in run_card.dat

…default FPTYPE from 'd' to 'm' (already the default cudacpp_backend in run_card.dat)

…5#995 (new options are [-dblonly|-fltonly|-d_f|-dmf])

…dacpp_config.mk

…-g 72h) with default FPTYPE='m' - all ok ./tput/allTees.sh -hip STARTED AT Sun 06 Oct 2024 09:01:55 AM EEST ./tput/teeThroughputX.sh -dmf -hrd -makej -eemumu -ggtt -ggttg -ggttgg -gqttq -ggttggg -makeclean -nocuda ENDED(1) AT Sun 06 Oct 2024 09:21:04 AM EEST [Status=0] ./tput/teeThroughputX.sh -d_f -hrd -makej -eemumu -ggtt -ggttgg -inlonly -makeclean -nocuda ENDED(2) AT Sun 06 Oct 2024 09:28:54 AM EEST [Status=0] ./tput/teeThroughputX.sh -makej -eemumu -ggtt -ggttg -gqttq -ggttgg -ggttggg -d_f -bridge -makeclean -nocuda ENDED(3) AT Sun 06 Oct 2024 09:42:23 AM EEST [Status=0] ./tput/teeThroughputX.sh -eemumu -ggtt -ggttgg -d_f -rmbhst -nocuda ENDED(4) AT Sun 06 Oct 2024 09:44:12 AM EEST [Status=0] SKIP './tput/teeThroughputX.sh -eemumu -ggtt -ggttgg -d_f -common -nocuda' ENDED(5) AT Sun 06 Oct 2024 09:44:12 AM EEST [Status=0] ./tput/teeThroughputX.sh -eemumu -ggtt -ggttgg -d_f -common -nocuda ENDED(6) AT Sun 06 Oct 2024 09:45:59 AM EEST [Status=0] ./tput/teeThroughputX.sh -dmf -hrd -makej -susyggtt -susyggt1t1 -smeftggtttt -heftggbb -makeclean -nocuda ENDED(7) AT Sun 06 Oct 2024 09:54:51 AM EEST [Status=0] No errors found in logs No FPEs or '{ }' found in logs

…YE='m' - all as expected (heft fail madgraph5#833, skip ggttggg madgraph5#933) ./tmad/allTees.sh -hip -no10x STARTED AT Sun 06 Oct 2024 09:54:51 AM EEST (SM tests) ENDED(1) AT Sun 06 Oct 2024 10:27:48 AM EEST [Status=0] (BSM tests) ENDED(1) AT Sun 06 Oct 2024 10:32:25 AM EEST [Status=0] 8 /users/valassia/GPU2024/madgraph4gpu/epochX/cudacpp/tmad/logs_eemumu_mad/log_eemumu_mad_d_inl0_hrd0.txt 8 /users/valassia/GPU2024/madgraph4gpu/epochX/cudacpp/tmad/logs_eemumu_mad/log_eemumu_mad_f_inl0_hrd0.txt 8 /users/valassia/GPU2024/madgraph4gpu/epochX/cudacpp/tmad/logs_eemumu_mad/log_eemumu_mad_m_inl0_hrd0.txt 6 /users/valassia/GPU2024/madgraph4gpu/epochX/cudacpp/tmad/logs_ggttggg_mad/log_ggttggg_mad_d_inl0_hrd0.txt 6 /users/valassia/GPU2024/madgraph4gpu/epochX/cudacpp/tmad/logs_ggttggg_mad/log_ggttggg_mad_f_inl0_hrd0.txt 6 /users/valassia/GPU2024/madgraph4gpu/epochX/cudacpp/tmad/logs_ggttggg_mad/log_ggttggg_mad_m_inl0_hrd0.txt 8 /users/valassia/GPU2024/madgraph4gpu/epochX/cudacpp/tmad/logs_ggttgg_mad/log_ggttgg_mad_d_inl0_hrd0.txt 8 /users/valassia/GPU2024/madgraph4gpu/epochX/cudacpp/tmad/logs_ggttgg_mad/log_ggttgg_mad_f_inl0_hrd0.txt 8 /users/valassia/GPU2024/madgraph4gpu/epochX/cudacpp/tmad/logs_ggttgg_mad/log_ggttgg_mad_m_inl0_hrd0.txt 8 /users/valassia/GPU2024/madgraph4gpu/epochX/cudacpp/tmad/logs_ggttg_mad/log_ggttg_mad_d_inl0_hrd0.txt 8 /users/valassia/GPU2024/madgraph4gpu/epochX/cudacpp/tmad/logs_ggttg_mad/log_ggttg_mad_f_inl0_hrd0.txt 8 /users/valassia/GPU2024/madgraph4gpu/epochX/cudacpp/tmad/logs_ggttg_mad/log_ggttg_mad_m_inl0_hrd0.txt 8 /users/valassia/GPU2024/madgraph4gpu/epochX/cudacpp/tmad/logs_ggtt_mad/log_ggtt_mad_d_inl0_hrd0.txt 8 /users/valassia/GPU2024/madgraph4gpu/epochX/cudacpp/tmad/logs_ggtt_mad/log_ggtt_mad_f_inl0_hrd0.txt 8 /users/valassia/GPU2024/madgraph4gpu/epochX/cudacpp/tmad/logs_ggtt_mad/log_ggtt_mad_m_inl0_hrd0.txt 8 /users/valassia/GPU2024/madgraph4gpu/epochX/cudacpp/tmad/logs_gqttq_mad/log_gqttq_mad_d_inl0_hrd0.txt 8 /users/valassia/GPU2024/madgraph4gpu/epochX/cudacpp/tmad/logs_gqttq_mad/log_gqttq_mad_f_inl0_hrd0.txt 8 /users/valassia/GPU2024/madgraph4gpu/epochX/cudacpp/tmad/logs_gqttq_mad/log_gqttq_mad_m_inl0_hrd0.txt 8 /users/valassia/GPU2024/madgraph4gpu/epochX/cudacpp/tmad/logs_heftggbb_mad/log_heftggbb_mad_d_inl0_hrd0.txt 1 /users/valassia/GPU2024/madgraph4gpu/epochX/cudacpp/tmad/logs_heftggbb_mad/log_heftggbb_mad_f_inl0_hrd0.txt 8 /users/valassia/GPU2024/madgraph4gpu/epochX/cudacpp/tmad/logs_heftggbb_mad/log_heftggbb_mad_m_inl0_hrd0.txt 8 /users/valassia/GPU2024/madgraph4gpu/epochX/cudacpp/tmad/logs_smeftggtttt_mad/log_smeftggtttt_mad_d_inl0_hrd0.txt 8 /users/valassia/GPU2024/madgraph4gpu/epochX/cudacpp/tmad/logs_smeftggtttt_mad/log_smeftggtttt_mad_f_inl0_hrd0.txt 8 /users/valassia/GPU2024/madgraph4gpu/epochX/cudacpp/tmad/logs_smeftggtttt_mad/log_smeftggtttt_mad_m_inl0_hrd0.txt 8 /users/valassia/GPU2024/madgraph4gpu/epochX/cudacpp/tmad/logs_susyggt1t1_mad/log_susyggt1t1_mad_d_inl0_hrd0.txt 8 /users/valassia/GPU2024/madgraph4gpu/epochX/cudacpp/tmad/logs_susyggt1t1_mad/log_susyggt1t1_mad_f_inl0_hrd0.txt 8 /users/valassia/GPU2024/madgraph4gpu/epochX/cudacpp/tmad/logs_susyggt1t1_mad/log_susyggt1t1_mad_m_inl0_hrd0.txt 8 /users/valassia/GPU2024/madgraph4gpu/epochX/cudacpp/tmad/logs_susyggtt_mad/log_susyggtt_mad_d_inl0_hrd0.txt 8 /users/valassia/GPU2024/madgraph4gpu/epochX/cudacpp/tmad/logs_susyggtt_mad/log_susyggtt_mad_f_inl0_hrd0.txt 8 /users/valassia/GPU2024/madgraph4gpu/epochX/cudacpp/tmad/logs_susyggtt_mad/log_susyggtt_mad_m_inl0_hrd0.txt

… tput/tmad logs Revert "[makefiles] rerun 30 tmad tests (-no10x) on LUMI/HIP with default FPTYE='m' - all as expected" This reverts commit 766ad8904af44d9ade37f6b1d398238374178bb5. Revert "[makefiles] rerun 96 tput builds and tests on LUMI worker node (small-g 72h) with default FPTYPE='m' - all ok" This reverts commit 7457eb6.

…YPE='m' - all ok STARTED AT Sun Oct 6 08:00:41 AM CEST 2024 ./tput/teeThroughputX.sh -dmf -hrd -makej -eemumu -ggtt -ggttg -ggttgg -gqttq -ggttggg -makeclean -cpponly ENDED(1) AT Sun Oct 6 08:31:44 AM CEST 2024 [Status=0] ./tput/teeThroughputX.sh -d_f -hrd -makej -eemumu -ggtt -ggttgg -inlonly -makeclean -cpponly ENDED(2) AT Sun Oct 6 08:49:04 AM CEST 2024 [Status=0] ./tput/teeThroughputX.sh -makej -eemumu -ggtt -ggttg -gqttq -ggttgg -ggttggg -d_f -bridge -makeclean -cpponly ENDED(3) AT Sun Oct 6 08:54:01 AM CEST 2024 [Status=0] ./tput/teeThroughputX.sh -eemumu -ggtt -ggttgg -d_f -rmbhst -cpponly ENDED(4) AT Sun Oct 6 08:55:29 AM CEST 2024 [Status=0] SKIP './tput/teeThroughputX.sh -eemumu -ggtt -ggttgg -d_f -common -cpponly' ENDED(5) AT Sun Oct 6 08:55:29 AM CEST 2024 [Status=0] ./tput/teeThroughputX.sh -eemumu -ggtt -ggttgg -d_f -common -cpponly ENDED(6) AT Sun Oct 6 08:56:56 AM CEST 2024 [Status=0] ./tput/teeThroughputX.sh -dmf -hrd -makej -susyggtt -susyggt1t1 -smeftggtttt -heftggbb -makeclean -cpponly ENDED(7) AT Sun Oct 6 09:06:19 AM CEST 2024 [Status=0] No errors found in logs No FPEs or '{ }' found in logs

…='m' - all as expected STARTED AT Sun Oct 6 09:06:19 AM CEST 2024 (SM tests) ENDED(1) AT Sun Oct 6 09:41:50 AM CEST 2024 [Status=0] (BSM tests) ENDED(1) AT Sun Oct 6 09:43:04 AM CEST 2024 [Status=0] 10 /data/avalassi/GPU2024/madgraph4gpuX/epochX/cudacpp/tmad/logs_eemumu_mad/log_eemumu_mad_d_inl0_hrd0.txt 10 /data/avalassi/GPU2024/madgraph4gpuX/epochX/cudacpp/tmad/logs_eemumu_mad/log_eemumu_mad_f_inl0_hrd0.txt 10 /data/avalassi/GPU2024/madgraph4gpuX/epochX/cudacpp/tmad/logs_eemumu_mad/log_eemumu_mad_m_inl0_hrd0.txt 10 /data/avalassi/GPU2024/madgraph4gpuX/epochX/cudacpp/tmad/logs_ggttggg_mad/log_ggttggg_mad_d_inl0_hrd0.txt 10 /data/avalassi/GPU2024/madgraph4gpuX/epochX/cudacpp/tmad/logs_ggttggg_mad/log_ggttggg_mad_f_inl0_hrd0.txt 10 /data/avalassi/GPU2024/madgraph4gpuX/epochX/cudacpp/tmad/logs_ggttggg_mad/log_ggttggg_mad_m_inl0_hrd0.txt 10 /data/avalassi/GPU2024/madgraph4gpuX/epochX/cudacpp/tmad/logs_ggttgg_mad/log_ggttgg_mad_d_inl0_hrd0.txt 10 /data/avalassi/GPU2024/madgraph4gpuX/epochX/cudacpp/tmad/logs_ggttgg_mad/log_ggttgg_mad_f_inl0_hrd0.txt 10 /data/avalassi/GPU2024/madgraph4gpuX/epochX/cudacpp/tmad/logs_ggttgg_mad/log_ggttgg_mad_m_inl0_hrd0.txt 10 /data/avalassi/GPU2024/madgraph4gpuX/epochX/cudacpp/tmad/logs_ggttg_mad/log_ggttg_mad_d_inl0_hrd0.txt 10 /data/avalassi/GPU2024/madgraph4gpuX/epochX/cudacpp/tmad/logs_ggttg_mad/log_ggttg_mad_f_inl0_hrd0.txt 10 /data/avalassi/GPU2024/madgraph4gpuX/epochX/cudacpp/tmad/logs_ggttg_mad/log_ggttg_mad_m_inl0_hrd0.txt 10 /data/avalassi/GPU2024/madgraph4gpuX/epochX/cudacpp/tmad/logs_ggtt_mad/log_ggtt_mad_d_inl0_hrd0.txt 10 /data/avalassi/GPU2024/madgraph4gpuX/epochX/cudacpp/tmad/logs_ggtt_mad/log_ggtt_mad_f_inl0_hrd0.txt 10 /data/avalassi/GPU2024/madgraph4gpuX/epochX/cudacpp/tmad/logs_ggtt_mad/log_ggtt_mad_m_inl0_hrd0.txt 10 /data/avalassi/GPU2024/madgraph4gpuX/epochX/cudacpp/tmad/logs_gqttq_mad/log_gqttq_mad_d_inl0_hrd0.txt 10 /data/avalassi/GPU2024/madgraph4gpuX/epochX/cudacpp/tmad/logs_gqttq_mad/log_gqttq_mad_f_inl0_hrd0.txt 10 /data/avalassi/GPU2024/madgraph4gpuX/epochX/cudacpp/tmad/logs_gqttq_mad/log_gqttq_mad_m_inl0_hrd0.txt 10 /data/avalassi/GPU2024/madgraph4gpuX/epochX/cudacpp/tmad/logs_heftggbb_mad/log_heftggbb_mad_d_inl0_hrd0.txt 1 /data/avalassi/GPU2024/madgraph4gpuX/epochX/cudacpp/tmad/logs_heftggbb_mad/log_heftggbb_mad_f_inl0_hrd0.txt 10 /data/avalassi/GPU2024/madgraph4gpuX/epochX/cudacpp/tmad/logs_heftggbb_mad/log_heftggbb_mad_m_inl0_hrd0.txt 10 /data/avalassi/GPU2024/madgraph4gpuX/epochX/cudacpp/tmad/logs_smeftggtttt_mad/log_smeftggtttt_mad_d_inl0_hrd0.txt 10 /data/avalassi/GPU2024/madgraph4gpuX/epochX/cudacpp/tmad/logs_smeftggtttt_mad/log_smeftggtttt_mad_f_inl0_hrd0.txt 10 /data/avalassi/GPU2024/madgraph4gpuX/epochX/cudacpp/tmad/logs_smeftggtttt_mad/log_smeftggtttt_mad_m_inl0_hrd0.txt 10 /data/avalassi/GPU2024/madgraph4gpuX/epochX/cudacpp/tmad/logs_susyggt1t1_mad/log_susyggt1t1_mad_d_inl0_hrd0.txt 10 /data/avalassi/GPU2024/madgraph4gpuX/epochX/cudacpp/tmad/logs_susyggt1t1_mad/log_susyggt1t1_mad_f_inl0_hrd0.txt 10 /data/avalassi/GPU2024/madgraph4gpuX/epochX/cudacpp/tmad/logs_susyggt1t1_mad/log_susyggt1t1_mad_m_inl0_hrd0.txt 10 /data/avalassi/GPU2024/madgraph4gpuX/epochX/cudacpp/tmad/logs_susyggtt_mad/log_susyggtt_mad_d_inl0_hrd0.txt 10 /data/avalassi/GPU2024/madgraph4gpuX/epochX/cudacpp/tmad/logs_susyggtt_mad/log_susyggtt_mad_f_inl0_hrd0.txt 10 /data/avalassi/GPU2024/madgraph4gpuX/epochX/cudacpp/tmad/logs_susyggtt_mad/log_susyggtt_mad_m_inl0_hrd0.txt

…put/tmad logs Revert "[makefiles] rerun 30 tmad tests (-no10x) on gold91 with default FPTYE='m' - all as expected" This reverts commit 9477e663292c229e60ea17cb0f40393dee09a64e. Revert "[makefiles] rerun 96 tput builds and tests on gold91 with default FPTYPE='m' - all ok" This reverts commit d409a85da6bdb2646bbeb94c1e69baca354898a2.

…FPTYPE='m' - all ok STARTED AT Sun Oct 6 08:00:06 AM CEST 2024 ./tput/teeThroughputX.sh -dmf -hrd -makej -eemumu -ggtt -ggttg -ggttgg -gqttq -ggttggg -makeclean ENDED(1) AT Sun Oct 6 09:15:05 AM CEST 2024 [Status=0] ./tput/teeThroughputX.sh -d_f -hrd -makej -eemumu -ggtt -ggttgg -inlonly -makeclean ENDED(2) AT Sun Oct 6 09:33:59 AM CEST 2024 [Status=0] ./tput/teeThroughputX.sh -makej -eemumu -ggtt -ggttg -gqttq -ggttgg -ggttggg -d_f -bridge -makeclean ENDED(3) AT Sun Oct 6 09:43:07 AM CEST 2024 [Status=0] ./tput/teeThroughputX.sh -eemumu -ggtt -ggttgg -d_f -rmbhst ENDED(4) AT Sun Oct 6 09:45:56 AM CEST 2024 [Status=0] ./tput/teeThroughputX.sh -eemumu -ggtt -ggttgg -d_f -curhst ENDED(5) AT Sun Oct 6 09:48:42 AM CEST 2024 [Status=0] ./tput/teeThroughputX.sh -eemumu -ggtt -ggttgg -d_f -common ENDED(6) AT Sun Oct 6 09:51:33 AM CEST 2024 [Status=0] ./tput/teeThroughputX.sh -dmf -hrd -makej -susyggtt -susyggt1t1 -smeftggtttt -heftggbb -makeclean ENDED(7) AT Sun Oct 6 10:03:47 AM CEST 2024 [Status=0] No errors found in logs No FPEs or '{ }' found in logs

…YE='m' - all as expected (heft fail madgraph5#833) STARTED AT Sat Oct 5 11:44:36 AM CEST 2024 (SM tests) ENDED(1) AT Sat Oct 5 04:19:38 PM CEST 2024 [Status=0] (BSM tests) ENDED(1) AT Sat Oct 5 04:34:29 PM CEST 2024 [Status=0] 24 /data/avalassi/GPU2023/madgraph4gpuX/epochX/cudacpp/tmad/logs_eemumu_mad/log_eemumu_mad_d_inl0_hrd0.txt 24 /data/avalassi/GPU2023/madgraph4gpuX/epochX/cudacpp/tmad/logs_eemumu_mad/log_eemumu_mad_f_inl0_hrd0.txt 24 /data/avalassi/GPU2023/madgraph4gpuX/epochX/cudacpp/tmad/logs_eemumu_mad/log_eemumu_mad_m_inl0_hrd0.txt 24 /data/avalassi/GPU2023/madgraph4gpuX/epochX/cudacpp/tmad/logs_ggttggg_mad/log_ggttggg_mad_d_inl0_hrd0.txt 24 /data/avalassi/GPU2023/madgraph4gpuX/epochX/cudacpp/tmad/logs_ggttggg_mad/log_ggttggg_mad_f_inl0_hrd0.txt 24 /data/avalassi/GPU2023/madgraph4gpuX/epochX/cudacpp/tmad/logs_ggttggg_mad/log_ggttggg_mad_m_inl0_hrd0.txt 24 /data/avalassi/GPU2023/madgraph4gpuX/epochX/cudacpp/tmad/logs_ggttgg_mad/log_ggttgg_mad_d_inl0_hrd0.txt 24 /data/avalassi/GPU2023/madgraph4gpuX/epochX/cudacpp/tmad/logs_ggttgg_mad/log_ggttgg_mad_f_inl0_hrd0.txt 24 /data/avalassi/GPU2023/madgraph4gpuX/epochX/cudacpp/tmad/logs_ggttgg_mad/log_ggttgg_mad_m_inl0_hrd0.txt 24 /data/avalassi/GPU2023/madgraph4gpuX/epochX/cudacpp/tmad/logs_ggttg_mad/log_ggttg_mad_d_inl0_hrd0.txt 24 /data/avalassi/GPU2023/madgraph4gpuX/epochX/cudacpp/tmad/logs_ggttg_mad/log_ggttg_mad_f_inl0_hrd0.txt 24 /data/avalassi/GPU2023/madgraph4gpuX/epochX/cudacpp/tmad/logs_ggttg_mad/log_ggttg_mad_m_inl0_hrd0.txt 24 /data/avalassi/GPU2023/madgraph4gpuX/epochX/cudacpp/tmad/logs_ggtt_mad/log_ggtt_mad_d_inl0_hrd0.txt 24 /data/avalassi/GPU2023/madgraph4gpuX/epochX/cudacpp/tmad/logs_ggtt_mad/log_ggtt_mad_f_inl0_hrd0.txt 24 /data/avalassi/GPU2023/madgraph4gpuX/epochX/cudacpp/tmad/logs_ggtt_mad/log_ggtt_mad_m_inl0_hrd0.txt 24 /data/avalassi/GPU2023/madgraph4gpuX/epochX/cudacpp/tmad/logs_gqttq_mad/log_gqttq_mad_d_inl0_hrd0.txt 24 /data/avalassi/GPU2023/madgraph4gpuX/epochX/cudacpp/tmad/logs_gqttq_mad/log_gqttq_mad_f_inl0_hrd0.txt 24 /data/avalassi/GPU2023/madgraph4gpuX/epochX/cudacpp/tmad/logs_gqttq_mad/log_gqttq_mad_m_inl0_hrd0.txt 24 /data/avalassi/GPU2023/madgraph4gpuX/epochX/cudacpp/tmad/logs_heftggbb_mad/log_heftggbb_mad_d_inl0_hrd0.txt 1 /data/avalassi/GPU2023/madgraph4gpuX/epochX/cudacpp/tmad/logs_heftggbb_mad/log_heftggbb_mad_f_inl0_hrd0.txt 24 /data/avalassi/GPU2023/madgraph4gpuX/epochX/cudacpp/tmad/logs_heftggbb_mad/log_heftggbb_mad_m_inl0_hrd0.txt 24 /data/avalassi/GPU2023/madgraph4gpuX/epochX/cudacpp/tmad/logs_smeftggtttt_mad/log_smeftggtttt_mad_d_inl0_hrd0.txt 24 /data/avalassi/GPU2023/madgraph4gpuX/epochX/cudacpp/tmad/logs_smeftggtttt_mad/log_smeftggtttt_mad_f_inl0_hrd0.txt 24 /data/avalassi/GPU2023/madgraph4gpuX/epochX/cudacpp/tmad/logs_smeftggtttt_mad/log_smeftggtttt_mad_m_inl0_hrd0.txt 24 /data/avalassi/GPU2023/madgraph4gpuX/epochX/cudacpp/tmad/logs_susyggt1t1_mad/log_susyggt1t1_mad_d_inl0_hrd0.txt 24 /data/avalassi/GPU2023/madgraph4gpuX/epochX/cudacpp/tmad/logs_susyggt1t1_mad/log_susyggt1t1_mad_f_inl0_hrd0.txt 24 /data/avalassi/GPU2023/madgraph4gpuX/epochX/cudacpp/tmad/logs_susyggt1t1_mad/log_susyggt1t1_mad_m_inl0_hrd0.txt 24 /data/avalassi/GPU2023/madgraph4gpuX/epochX/cudacpp/tmad/logs_susyggtt_mad/log_susyggtt_mad_d_inl0_hrd0.txt 24 /data/avalassi/GPU2023/madgraph4gpuX/epochX/cudacpp/tmad/logs_susyggtt_mad/log_susyggtt_mad_f_inl0_hrd0.txt 24 /data/avalassi/GPU2023/madgraph4gpuX/epochX/cudacpp/tmad/logs_susyggtt_mad/log_susyggtt_mad_m_inl0_hrd0.txt

git checkout banner $(git ls-tree --name-only banner */CODEGEN*txt)

Fix conflicts: epochX/cudacpp/CODEGEN/PLUGIN/CUDACPP_SA_OUTPUT/CHANGELOG.md

…g of matrix1.pdf to avoid unnecessary changes

valassi · 2024-10-07T08:20:06Z

Hi @oliviermattelaer as discussed. This is N=2 in my PR pipeline.

Sorry I cannot change the target yet to ease the comparison... if you want, I will create the branches on the madgraph5 repo (they are in my for now).

Anyway the changes are here
valassi/madgraph4gpu@banner...valassi:madgraph4gpu:makefiles

Can you have a look please? Or tell me and I will create a branch upstream

valassi · 2024-10-07T08:26:17Z

Voila I changed the target so now it's easier to review.

But I would then merge it to master once reviewd and approved

oliviermattelaer · 2024-10-08T07:42:34Z

So this change is something that I can approve (but I do not approve the base branch, so we either have to wait or to cherry-pick).

valassi · 2024-10-08T14:22:50Z

So this change is something that I can approve (but I do not approve the base branch, so we either have to wait or to cherry-pick).

Thanks Olivier :-)

Ok moved back to draft while iterating on the base PR

git checkout banner $(git ls-tree --name-only banner */CODEGEN*txt)

… makefiles

valassi · 2024-10-08T20:00:40Z

Moving back to ready for review and merging, after doing the requested changes in the base PR #1016.

oliviermattelaer

I confirm that this is good to go.

Thanks,

Olivier

…controlled by floating_type not by cudacpp_backend

…ixing comments in cudacpp_config.mk

…G.md: FPTYPE in runcards is controlled by floating_type not by cudacpp_backend

valassi · 2024-10-08T20:16:54Z

I confirm that this is good to go.

Thanks,

Olivier

Thanks Olivier :-)

(For info: I force pushed some changes in comments, the FPTYPE runcard is called floating_type, not cudacpp_backend...)

Merging now
Andrea

valassi · 2024-10-08T20:18:03Z

(And I changed the base: merging to master, not to a fake branch that I had created only to make changes more visible)

Merging

valassi added 4 commits October 6, 2024 07:46

[makefiles] in CODEGEN cudacpp_config.mk, move the default FPTYPE fro…

6be4ba8

…m 'd' to 'm' (madgraph5#995), to be consistent with cudacpp_backend in run_card.dat

[makefiles] in CHANGELOG.md: madgraph5#995 in cudacpp_config.mk move …

d686d44

…default FPTYPE from 'd' to 'm' (already the default cudacpp_backend in run_card.dat)

[makefiles] adapt tput scripts to the new default fptype 'm' madgraph…

25a1940

…5#995 (new options are [-dblonly|-fltonly|-d_f|-dmf])

[makefiles] regenerate all processes, with new default FPTYPE=m in cu…

c6289bd

…dacpp_config.mk

valassi self-assigned this Oct 6, 2024

valassi added 12 commits October 6, 2024 10:39

[makefiles] move to codegen logs from banner branch to ease merging

98df91b

git checkout banner $(git ls-tree --name-only banner */CODEGEN*txt)

Merge branch 'banner' into makefiles

bee466d

Fix conflicts: epochX/cudacpp/CODEGEN/PLUGIN/CUDACPP_SA_OUTPUT/CHANGELOG.md

[makefiles] in CODEGEN/generateAndCompare.sh, further improve handlin…

82a01d1

…g of matrix1.pdf to avoid unnecessary changes

[makefiles] regenerate all processes - no change

c7a0bd5

valassi requested a review from oliviermattelaer October 7, 2024 08:13

valassi changed the title ~~Move default fptype to m in cudacpp makefiles and scripts~~ (2 in pipeline) - Move default fptype to m in cudacpp makefiles and scripts Oct 7, 2024

valassi changed the base branch from master to valassi_1_banner October 7, 2024 08:25

valassi marked this pull request as draft October 8, 2024 14:22

valassi added 2 commits October 8, 2024 21:46

[makefiles] move to new codegen logs from banner branch to ease merging

8a711c0

git checkout banner $(git ls-tree --name-only banner */CODEGEN*txt)

Merge branch 'banner' (after removing plugin_input in mg5amcnlo) into…

4b29b6d

… makefiles

valassi marked this pull request as ready for review October 8, 2024 19:59

oliviermattelaer approved these changes Oct 8, 2024

View reviewed changes

valassi added 3 commits October 8, 2024 22:14

[makefiles] fix comments in cudacpp_config.mk: FPTYPE in runcards is …

f998d12

…controlled by floating_type not by cudacpp_backend

[makefiles] regenerate all processes after merging banner again and f…

72a64de

…ixing comments in cudacpp_config.mk

[makefiles] ** COMPLETE MAKEFILES (again) ** fix comments in CHANGELO…

7192d06

…G.md: FPTYPE in runcards is controlled by floating_type not by cudacpp_backend

valassi force-pushed the makefiles branch from 1f1ae23 to 7192d06 Compare October 8, 2024 20:15

valassi changed the title ~~(2 in pipeline) - Move default fptype to m in cudacpp makefiles and scripts~~ Move default fptype to m in cudacpp makefiles and scripts Oct 8, 2024

valassi changed the base branch from valassi_1_banner to master October 8, 2024 20:17

valassi merged commit 7e55785 into madgraph5:master Oct 8, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Move default fptype to m in cudacpp makefiles and scripts#1017

Move default fptype to m in cudacpp makefiles and scripts#1017
valassi merged 21 commits intomadgraph5:masterfrom
valassi:makefiles

valassi commented Oct 6, 2024

Uh oh!

valassi commented Oct 7, 2024

Uh oh!

valassi commented Oct 7, 2024

Uh oh!

oliviermattelaer commented Oct 8, 2024

Uh oh!

valassi commented Oct 8, 2024

Uh oh!

valassi commented Oct 8, 2024

Uh oh!

oliviermattelaer left a comment

Uh oh!

valassi commented Oct 8, 2024

Uh oh!

valassi commented Oct 8, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

valassi commented Oct 6, 2024

Uh oh!

valassi commented Oct 7, 2024

Uh oh!

valassi commented Oct 7, 2024

Uh oh!

oliviermattelaer commented Oct 8, 2024

Uh oh!

valassi commented Oct 8, 2024

Uh oh!

valassi commented Oct 8, 2024

Uh oh!

oliviermattelaer left a comment

Choose a reason for hiding this comment

Uh oh!

valassi commented Oct 8, 2024

Uh oh!

valassi commented Oct 8, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants