Adds task 12 #24
Closed
Adds task 12 #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Const should be used for unchanged variables
const should be used for variables that do not change
let should be used for vaiables that change and const for those that doesn't
- the variable changes so it can be let
- the variable can be declared in the for loop
- === is prefered over == unless checking for falsy/truthy values
- if should have {} for improved readability
- uses let not var - matches the brackets accross the functions
- also matches the formatting to the other functions
jamesgeorge007
force-pushed
the
js-tasks
branch
from
fac95f0 to
334267a
Compare
jamesgeorge007
requested changes
Oct 6, 2019
Member
jamesgeorge007
left a comment
jamesgeorge007
left a comment
There was a problem hiding this comment.
It seems that you've checked out from the wrong branch which made those commits appear here. Kindly clean up your branch.
Contributor
Author
|
Things got screwy so I have made it again |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds task 12 to the JS branch. The task is on functions
Fixes #5 partially (issue)
Type of change
Please delete options that are not relevant.
Checklist: