Skip to content

Conversation

@SSmale
Copy link
Contributor

@SSmale SSmale commented Oct 6, 2019

redo of #24

@jamesgeorge007 jamesgeorge007 self-requested a review October 6, 2019 07:20
@jamesgeorge007 jamesgeorge007 added enhancement New feature or request Hacktoberfest labels Oct 6, 2019
@jamesgeorge007 jamesgeorge007 added this to the v1.2.0 milestone Oct 6, 2019
Copy link
Member

@jamesgeorge007 jamesgeorge007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove those comments as they aren't intended with json files.

Copy link
Contributor Author

@SSmale SSmale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes made

Copy link
Contributor Author

@SSmale SSmale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have removed comments

@SSmale SSmale requested a review from jamesgeorge007 October 6, 2019 07:49
Co-Authored-By: James George <jamesgeorge998001@gmail.com>
@jamesgeorge007 jamesgeorge007 merged commit 64e4bae into madlabsinc:js-tasks Oct 6, 2019
jamesgeorge007 added a commit that referenced this pull request Oct 19, 2019
* Chore(Task List): adds the task number for readability

* Fix(Task 11): adds the missing answer for task 11

* Feat(Task 12): adds task 12 and the solution

* Fix(Tasks List): removes the task comment

* fix(typos)

Co-Authored-By: James George <jamesgeorge998001@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Hacktoberfest

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants