Improve logging on Completer #285
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not sure if exposing a Log method is the best way to go, but wanted to respect the debug configuration.
The idea is to make it more explicit that on error situations the offset returned is zero. The function was doing that but in a way that we had to check if the offset var was not being assigned to some value, in the end it never is, it is always 0 (or I got something wrong).
The var was never initialized, maybe it could be some sort of empty/default thing, but the name was at least misleading. Since the function returns a slice just using nil for empty slice is idiomatic in Go and should work.
katcipis
changed the title
Codecov Report
@@ Coverage Diff @@
## master #285 +/- ##
==========================================
- Coverage 42.32% 41.75% -0.57%
==========================================
Files 52 52
Lines 7318 6378 -940
==========================================
- Hits 3097 2663 -434
+ Misses 3931 3429 -502
+ Partials 290 286 -4
Continue to review full report at Codecov.
|
Collaborator
|
wow this is old, sorry =( |
i4ki
approved these changes
Jan 12, 2023
|
fala xiru véio!
Best Regards,
Alfredo Tomio Junior
+31 684431787
…On Fri, Jan 13, 2023 at 1:30 AM Tiago Cesar Katcipis < ***@***.***> wrote:
Merged #285 <#285> into master.
—
Reply to this email directly, view it on GitHub
<#285 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABGWUICAORDDFAUOBE7FVHLWSCO37ANCNFSM4TQ2V3MA>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if exposing a Log method is the best way to go, but wanted to respect the debug configuration.