fix: Add missing replacement of VGFMAFLAG in configure#1171
Closed
rwolke wants to merge 1 commit intomadler:developfrom
Closed
fix: Add missing replacement of VGFMAFLAG in configure#1171rwolke wants to merge 1 commit intomadler:developfrom
rwolke wants to merge 1 commit intomadler:developfrom
Conversation
Owner
|
Applied. |
|
Er, where? |
Owner
|
Locally. Not pushed yet. |
giuseppe
added a commit
to giuseppe/crun
that referenced
this pull request
Mar 24, 2026
zlib's configure script detects s390x vector extensions but fails to export VGFMAFLAG, causing the build to fail with '__builtin_s390_vec_*' requires '-mvx'. Apply the upstream fix (madler/zlib#1171) as a patch, gated behind an overlay that only activates for s390x builds. Upstream: madler/zlib#1200 Fix: NixOS/nixpkgs#502917 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
giuseppe
added a commit
to giuseppe/crun
that referenced
this pull request
Mar 24, 2026
zlib's configure script detects s390x vector extensions but fails to export VGFMAFLAG, causing the build to fail with '__builtin_s390_vec_*' requires '-mvx'. Apply the upstream fix (madler/zlib#1171) as a patch, gated behind an overlay that only activates for s390x builds. Upstream: madler/zlib#1200 Fix: NixOS/nixpkgs#502917 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
giuseppe
added a commit
to giuseppe/crun
that referenced
this pull request
Mar 24, 2026
zlib's configure script detects s390x vector extensions but fails to export VGFMAFLAG, causing the build to fail with '__builtin_s390_vec_*' requires '-mvx'. Apply the upstream fix (madler/zlib#1171) as a patch, gated behind an overlay that only activates for s390x builds. Upstream: madler/zlib#1200 Fix: NixOS/nixpkgs#502917 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
giuseppe
added a commit
to giuseppe/crun
that referenced
this pull request
Mar 25, 2026
zlib's configure script detects s390x vector extensions but fails to export VGFMAFLAG, causing the build to fail with '__builtin_s390_vec_*' requires '-mvx'. Apply the upstream fix (madler/zlib#1171) as a patch, gated behind an overlay that only activates for s390x builds. Upstream: madler/zlib#1200 Fix: NixOS/nixpkgs#502917 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
giuseppe
added a commit
to giuseppe/crun
that referenced
this pull request
Mar 25, 2026
zlib's configure script detects s390x vector extensions but fails to export VGFMAFLAG, causing the build to fail with '__builtin_s390_vec_*' requires '-mvx'. Apply the upstream fix (madler/zlib#1171) as a patch, gated behind an overlay that only activates for s390x builds. Upstream: madler/zlib#1200 Fix: NixOS/nixpkgs#502917 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
gentoo-bot
pushed a commit
to gentoo/gentoo
that referenced
this pull request
Mar 30, 2026
Bug: madler/zlib#1200 See-also: madler/zlib#1171 Signed-off-by: Andreas K. Hüttel <dilfridge@gentoo.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The variable VGFMAFLAG is set in the configure script, but will not be exported to the Makefile. Therefore, builds on s390x will fail.
This patch adds the missing replacements.