Skip to content

Removed incorrect generator expression usage#1226

Open
arnauddgbes wants to merge 1 commit into
madler:developfrom
arnauddgbes:fix/minizip-windows
Open

Removed incorrect generator expression usage#1226
arnauddgbes wants to merge 1 commit into
madler:developfrom
arnauddgbes:fix/minizip-windows

Conversation

@arnauddgbes
Copy link
Copy Markdown

CMake generator expressions cannot be used in the set function, resulting is implementations missing from the runtime libraries, and missing header files in the installation.

CMake generator expressions cannot be used in the set function, resulting is implementations missing from the runtime libraries, and missing header files in the installation.
@Vollstrecker
Copy link
Copy Markdown
Contributor

Maybe you didn't notice the work done in fixes-1.3.2 which is merged but not pushed yet. I just opened another fixes-PR as some more was to be done.

Long story short: Take a look at #1233 to see the current state of the tree.

@arnauddgbes
Copy link
Copy Markdown
Author

As such there is no overlap between both PR. Are you going to apply #1226 into #1233?

@Vollstrecker
Copy link
Copy Markdown
Contributor

Right, missed that one. Will be incorporated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants