Skip to content

Comments

minizip: close filestream on error in zipOpen3()#401

Closed
a-kulakov wants to merge 1 commit intomadler:developfrom
a-kulakov:minizip-close-handle-on-error
Closed

minizip: close filestream on error in zipOpen3()#401
a-kulakov wants to merge 1 commit intomadler:developfrom
a-kulakov:minizip-close-handle-on-error

Conversation

@a-kulakov
Copy link

As on error with zi ALLOC, ZCLOSE64() should match ZOPEN64() at the beginning of the function.

@praiskup
Copy link

Minizip contrib module is not maintained here. See #229, #211, #210, #209. Take a look at https://github.com/nmoinvaz/minizip

@a-kulakov
Copy link
Author

@praiskup - Pavel, thanks. Your comments in #229 was especially helpful. And silence in reply :-)
Helped me to understand that I should close this pull request.

@madler - "zlib on github" link on http://zlib.net or zlib Faq may be a proper place to point out that pull requests with changes in ./contrib should not be created, etc. Please consider to put clear statement somewhere.

@a-kulakov
Copy link
Author

Well, learned that "UNSUPPORTED" in README.contrib also means that pull requests just ignored :-)

@a-kulakov a-kulakov closed this Apr 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants