solution for VS 22, fix for Windows build#644
Closed
kaoh wants to merge 1 commit intomadler:masterfrom
Closed
Conversation
Author
|
I guess, the built failed, but the error message seems to be not related to my pull request. |
Closed
Owner
|
Missing exports and prototypes addressed. You may check the develop branch and suggest any contrib/vstudio changes relative to that branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is adding support for compilation under Windows using VS 22 and using standard calling convention.
In addition it is fixing a missing
ZEXPORTforcrc32_combine_opand missing prototypes forcrc32_combine64andcrc32_combine_gen64for the VC compiler. The last two functions are called from the 32 bit versions, maybe this can also be improved.