Skip to content

Conversation

@dgmz
Copy link

@dgmz dgmz commented May 28, 2014

Changes and project files to compile with Visual Studio 2013.

Daniel Guerrero added 2 commits May 28, 2014 12:06
The version number in zlibvc.def had to be truncated to 1.2 because the latest version of the Microsoft tools became a little more picky about the syntax. This is cosmetic, though.
…t SEH (Secure Exception Handling) flag.

I'm not sure this has any useful effect besides making the linker happy.
@rhuijben
Copy link

I don't think the assembly files 'fix' should be merged. This should be fixed by BOTH fixing issue #41 and then by updating the assembly build to properly produce SEH information.

@dgmz
Copy link
Author

dgmz commented May 28, 2014

Indeed. Maybe disabling the assembly optimizations should be considered until thay get fixed.

Thanks for the heads-up.

De: Bert Huijben [mailto:notifications@github.com]
Enviado el: miércoles, 28 de mayo de 2014 12:19
Para: madler/zlib
CC: dgmz
Asunto: Re: [zlib] Vc12 (#71)

I don't think the assembly files 'fix' should be merged. This should be fixed by BOTH fixing issue #41 #41 and then by updating the assembly build to properly produce SEH information.


Reply to this email directly or view it on GitHub #71 (comment) .Imagen quitada por el remitente.

@madler
Copy link
Owner

madler commented Dec 31, 2016

There are many Visual Studio pull requests. Can someone who is able to test them across versions of Visual Studio merge them into a single pull request? Also please test it with the latest zlib develop branch here on github, and account for functions that have been added since 1.2.8. Thank you.

@AraHaan
Copy link
Contributor

AraHaan commented Dec 31, 2016

See #182 which is based from #167. Other than that it also Provides some other fixes to the definition file and the resource script for the version info resource. The export Definition file was also fixed in it for all of the Project files and includes VS2013 for those who still use it. It targets the latest Develop branch though.

@madler
Copy link
Owner

madler commented Jan 2, 2017

Please see zlib 1.2.9 for updated vstudio support. Please create new issues or new pull requests if there are problems or desired behaviors against that version. Thanks.

@madler madler closed this Jan 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants