Skip to content

Conversation

@ownadi
Copy link
Contributor

@ownadi ownadi commented Mar 13, 2019

This feature is useful when one needs more predictable shuffles.

@madox2
Copy link
Owner

madox2 commented Mar 14, 2019

Hi, thanks for contribution! But I personally find this functionality too specific and I am not sure whether it should be part of the tag cloud. Wouldn't be easier to disable shuffle and pass already shuffled tags (whatever algorithm) into tag cloud?

@ownadi
Copy link
Contributor Author

ownadi commented Mar 14, 2019

Personally, I find this feature very convenient and useful. In the way you described, do we need shuffle feature at all? One could always randomize the data outside of the cloud.
I've switched from a similar package (react-tag-cloud), which allows overriding rng, and I miss this possibility here. It's obviously totally optional, so most users totally don't need to care about.
Thank you for your work on this library!

@madox2
Copy link
Owner

madox2 commented Mar 14, 2019

Alright if you think that it might be beneficial also for other users, I have nothing against it. I would only rename the property to something more meaningful at the first sight, e.g. randomNumberGenerator

@ownadi
Copy link
Contributor Author

ownadi commented Mar 14, 2019

Sure, it will be better name.

@madox2 madox2 merged commit dd21fa1 into madox2:master Mar 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants