Added fuzz testing #4

dcapwell · 2022-09-14T00:36:18Z

No description provided.

patch by Caleb Rackliffe; reviewed by ? for CASSANDRA-17719 Co-authored-by: Caleb Rackliffe <calebrackliffe@gmail.com> Co-authored-by: Blake Eggleston <bdeggleston@gmail.com>

…d of waiting for system keyspace state

dcapwell · 2022-09-17T01:46:40Z

src/java/org/apache/cassandra/db/marshal/UserType.java

actual bug, but only impacts toCQL so limited issue... too little for its own JIRA =(

src/java/org/apache/cassandra/exceptions/AccordTimeoutException.java

src/java/org/apache/cassandra/service/accord/AccordCallback.java

dcapwell · 2022-09-17T01:54:10Z

src/java/org/apache/cassandra/service/accord/AccordCallback.java

I worked on a patch recently to make it so expires w/ timeout returns timeout, so would be best for Accord not to regress this...

dcapwell · 2022-09-17T01:54:45Z

src/java/org/apache/cassandra/service/accord/api/AccordKey.java

see org.apache.cassandra.cql3.QueryProcessor#validateKey

fix set element selection to work w/ Selectable -> ColumnReference conversion clean up SELECT disambiguation and use selectionGroup instead of columnReference to parse references in SELECT

dcapwell · 2022-10-04T15:14:07Z

src/antlr/Parser.g

thinking that ReferenceOperation.Assignment.Raw shouldn't take the ReferenceValue.Raw and should pull from the Operation, this would help later on when we add support for more complex Operations.

dcapwell · 2022-10-04T15:14:48Z

src/java/org/apache/cassandra/cql3/ColumnReference.java

for debugging it was just so much easier to say "who" was broken

dcapwell · 2022-10-04T15:16:55Z

src/java/org/apache/cassandra/cql3/ColumnReference.java

using .name() here as we know its a user type; we don't use this when dealing with auto-gen reads

dcapwell · 2022-10-04T15:20:50Z

src/java/org/apache/cassandra/cql3/statements/ModificationStatement.java

this doesn't actually matter as this is used to say if the statement as a whole needs to read... but we don't want that in a txn... ill look to clean this up when trying to avoid the read

dcapwell · 2022-10-04T15:21:08Z

src/java/org/apache/cassandra/cql3/statements/ModificationStatement.java

need to look closer at what this does... I just copy/pasted

…me generalization of utilities into AuthTestUtils)

…w it to work w/ TxnBuilder / TxnData (thereby "completing" the last rebase on the metadata-persistence branch)

…ELECT

… ones. Operations are now used for the core logic rather than forking, and Operations that requireRead are converted to a ReferenceOperation

…mnReference to parse references in SELECT

…ings more complex for Accord

bdeggleston and others added 11 commits September 12, 2022 16:14

CQL support for CEP-15 multi-partition transactions

f423879

patch by Caleb Rackliffe; reviewed by ? for CASSANDRA-17719 Co-authored-by: Caleb Rackliffe <calebrackliffe@gmail.com> Co-authored-by: Blake Eggleston <bdeggleston@gmail.com>

convert AccordUpdateTest to TxnUpdateTest

ba04810

changed a few more integration tests to use a read transaction instea…

d58175e

…d of waiting for system keyspace state

reject (at least for now) SELECTs that can read more than one row

5f1660c

some initial support for bind variables

3b94799

Compiles on JDK8

3e88462

bind variable support for IF

b3b4bb3

make sure SELECT references are disambiguated across tuples

583d320

NODE_LOCAL queries work now (by delegating to normal execution)

fef8b25

support quoted column names in the grammar

a6ff33f

move ReferenceSource to ColumnReference

072160a

dcapwell force-pushed the feedback/CASSANDRA-17719-post-simulator branch 2 times, most recently from b1d64ce to 6f83568 Compare September 17, 2022 01:43

dcapwell commented Sep 17, 2022

View reviewed changes

src/java/org/apache/cassandra/exceptions/AccordTimeoutException.java Outdated Show resolved Hide resolved

dcapwell commented Sep 17, 2022

View reviewed changes

src/java/org/apache/cassandra/service/accord/AccordCallback.java Outdated Show resolved Hide resolved

dcapwell commented Sep 17, 2022

View reviewed changes

src/java/org/apache/cassandra/service/accord/api/AccordKey.java Outdated

Copy link

Author

dcapwell Sep 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see org.apache.cassandra.cql3.QueryProcessor#validateKey

maedhroz added 6 commits September 17, 2022 00:54

initial support for unfrozen collections

4f89c79

multi-cell list references for SELECT/IF in TransactionStatementTest

c108d43

cleaned up a bunch of the txn booleans that aren't being used

f84918f

make sure quoted tuple names parse properly

f8360c8

support for NULL/NOT NULL conditions on entire collections

6852029

fixed cqlsh's handling of the IF...THEN...END IF elements

1d276ce

dcapwell force-pushed the feedback/CASSANDRA-17719-post-simulator branch from 2e8c4c8 to f6fc073 Compare September 20, 2022 21:50

initial support for non-frozen list substitutions within updates

719cd4b

dcapwell force-pushed the feedback/CASSANDRA-17719-post-simulator branch from 5fa7f64 to db8839a Compare September 21, 2022 20:55

maedhroz added 3 commits September 22, 2022 10:18

minor type safety fix

332e860

list replacement works now (instead of concatenating)

b98ce9e

support for list concatenation

fd5d8dc

support for shorthand list subtraction

72fa57a

dcapwell force-pushed the feedback/CASSANDRA-17719-post-simulator branch from ce133da to cd8e977 Compare September 23, 2022 19:54

initial support for set selection and set element selection

67bd866

maedhroz force-pushed the CASSANDRA-17719-post-simulator branch from 8ab73ee to e99a798 Compare September 24, 2022 01:34

dcapwell force-pushed the feedback/CASSANDRA-17719-post-simulator branch from e02bf6a to c0f7dcb Compare September 27, 2022 23:41

maedhroz added 2 commits September 27, 2022 22:09

simplified the grammar a bit around reference-based +=/-+ operators

9e745da

fix set element selection to work w/ Selectable -> ColumnReference conversion clean up SELECT disambiguation and use selectionGroup instead of columnReference to parse references in SELECT

remove row index cruft we won't need for v1

5b242c1

maedhroz force-pushed the CASSANDRA-17719-post-simulator branch from 5651f1e to 5b242c1 Compare September 28, 2022 03:10

dcapwell force-pushed the feedback/CASSANDRA-17719-post-simulator branch from cba1e88 to d54c3fc Compare October 4, 2022 15:04

dcapwell commented Oct 4, 2022

View reviewed changes

src/java/org/apache/cassandra/cql3/ColumnReference.java Outdated

Copy link

Author

dcapwell Oct 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for debugging it was just so much easier to say "who" was broken

dcapwell commented Oct 4, 2022

View reviewed changes

maedhroz and others added 11 commits October 6, 2022 22:56

add authorization support for TransactionStatement (which prompted so…

004aba4

…me generalization of utilities into AuthTestUtils)

bring PairOfSequencesAccordSimulation back w/ minor changes that allo…

ee87cbd

…w it to work w/ TxnBuilder / TxnData (thereby "completing" the last rebase on the metadata-persistence branch)

failing test for pulling partition and clustering key references in S…

1e5a190

…ELECT

TxnData is now keyed on a URN to isolate user variables from internal…

78b5b80

… ones. Operations are now used for the core logic rather than forking, and Operations that requireRead are converted to a ReferenceOperation

added back symbol gen

54049a8

added a test to show if reversed types work

670687a

cleanup txndataname to no longer compress and to reuse RETURN

13e2555

todo

ddaf3ee

fixed tests

9f1db69

clean up SELECT disambiguation and use selectionGroup instead of colu…

025931c

…mnReference to parse references in SELECT

Removed RegularAndStaticColumns from UP as its dead code and makes th…

91f148f

…ings more complex for Accord

dcapwell force-pushed the feedback/CASSANDRA-17719-post-simulator branch from 7bc6a70 to 91f148f Compare October 10, 2022 23:05

maedhroz force-pushed the CASSANDRA-17719-post-simulator branch 2 times, most recently from c579a48 to 61512ca Compare October 12, 2022 22:49

maedhroz changed the base branch from CASSANDRA-17719-post-simulator to CASSANDRA-17719 October 31, 2022 19:04

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Added fuzz testing #4

Added fuzz testing #4

Uh oh!

dcapwell commented Sep 14, 2022

Uh oh!

dcapwell Sep 17, 2022

Uh oh!

Uh oh!

Uh oh!

dcapwell Sep 17, 2022

Uh oh!

dcapwell Sep 17, 2022

Uh oh!

dcapwell Oct 4, 2022

Uh oh!

dcapwell Oct 4, 2022

Uh oh!

dcapwell Oct 4, 2022

Uh oh!

dcapwell Oct 4, 2022

Uh oh!

dcapwell Oct 4, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Added fuzz testing #4

Are you sure you want to change the base?

Added fuzz testing #4

Uh oh!

Conversation

dcapwell commented Sep 14, 2022

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants