added investigate to the ui and skipped the places it was missing by Mynster9361 · Pull Request #1659 · maester365/maester

Mynster9361 · 2026-04-15T21:44:41Z

Description

Fixes #1457
Invesatigate is now correctly displayed in the "By category" section.
Is now also shown in the top bar and "Test status" Skipped has also been added will add a picture in a comment on this PR

Contribution Checklist

Before submitting this PR, please confirm you have completed the following:

📖 Read the guidelines for contributing to this repository.
🧪 Ensure the build and unit tests pass by running /powershell/tests/pester.ps1 on your local system.

Join us at the Maester repository discussions 💬 or Entra Discord 🧑‍💻 for more help and conversations!

…t test to verify existing test is updated to new framework version

…v6.0.1 next up going through existing content and markdown details

… diffrent cis tests

… all of them and reference to CIS Microsoft 365 Foundations Benchmark v6.0.1 in Tests

…was updated so a few was missing in the list even though they were implemented

@SamErde

… the website which means the links would be broken when building the maester application in docusaurus @SamErde please take a look at this one and see if it is up to par :)

… modified the testResults.ts for better visibility to investigatecount

codacy-production · 2026-04-15T21:46:12Z

Not up to standards ⛔

_{TIP This summary will be updated as you push new changes. Give us feedback}

Mynster9361 · 2026-04-15T21:50:42Z

Hoping below pictures will help show the changes :)

Before:

After:

Copilot

Pull request overview

Updates the Maester report UI to properly include the Investigate (and Skipped) statuses in key visualizations, addressing the missing “Investigate” representation in the “By category” chart (issue #1457).

Changes:

Adds Investigate as a category in the “By category” area chart.
Updates the “Test status” donut chart to include Skipped in both the chart and legend/percentages.
Adjusts the report’s sample testResults data to include a non-zero InvestigateCount.

Reviewed changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.

File	Description
report/src/lib/testResults.ts	Updates placeholder/sample report data used by the frontend template.
report/src/components/MtDonutChart.jsx	Adds “Skipped” to the donut chart and percentage calculation.
report/src/components/MtBlocksArea.jsx	Adds “Investigate” to the By-category area chart series and colors.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

merill · 2026-04-16T11:14:32Z

@Mynster9361 thanks for this PR

Not including Skipped in the charts was intentional. We don't want to penalize the pass/fail for skipped tests.

Tests can be skipped for various reasons including licensing. So it wouldn't be fair to the customer to say they only passed 25% of the tests when in fact they are in a much healthier state for their licensing level.

On the bug raised in #1457, that's a valid ask and we can definitely take that part of the PR to include Investigate in the category chart.

Thoughts? If you agree, can you update the PR to just fix #1457?

Mynster9361 · 2026-04-16T12:07:02Z

@Mynster9361 thanks for this PR

Not including Skipped in the charts was intentional. We don't want to penalize the pass/fail for skipped tests.

Tests can be skipped for various reasons including licensing. So it wouldn't be fair to the customer to say they only passed 25% of the tests when in fact they are in a much healthier state for their licensing level.

On the bug raised in #1457, that's a valid ask and we can definitely take that part of the PR to include Investigate in the category chart.

Thoughts? If you agree, can you update the PR to just fix #1457?

@merill
Agreed i will remove the skipped from the donut wheel just felt like it should be there when it was every where else.
Will update the PR a bit later today.

Question though Is there any plans on including some license requirements for tests that was skipped due to license so we can acurately show how much extra gets added from license to license?

Mynster9361 · 2026-04-16T16:40:49Z

The ui now looks like this

@SamErde @merill
Let me know if other changes are needed :)

SamErde

LGTM! Have you built and tested the report template locally already?

Mynster9361 · 2026-04-16T20:28:50Z

LGTM! Have you built and tested the report template locally already?

yup the ReportTemplate.html is included in the pr even if it is not needed following the docs :)

SamErde · 2026-04-17T02:01:58Z

In addition to adding Investigate, this also adds a Not Tested card to the top.

There is something nice about having all potential values represented for the sake of clarity.
To be honest, it does make the top bar of cards feel rather busy to me, and I'm not sure if I like that aspect of it yet.

As an aside -- something for a different PR -- it would be really nice if the status cards were each hyperlinks that set the filter in the list below. For example, click the Investigate card to filter the list to show only tests with the Investigate status.

Mynster9361 · 2026-04-17T16:47:29Z

In addition to adding Investigate, this also adds a Not Tested card to the top.

There is something nice about having all potential values represented for the sake of clarity.

To be honest, it does make the top bar of cards feel rather busy to me, and I'm not sure if I like that aspect of it yet.

As an aside -- something for a different PR -- it would be really nice if the status cards were each hyperlinks that set the filter in the list below. For example, click the Investigate card to filter the list to show only tests with the Investigate status.

I do agree there is a lot in the top tbf i did not even notice when i made the additional changes it felt natural to me to at least have somewhere to visually show how many tests where not run for one reason or another.

I like the idea about adding the filtration but that would properly go into another PR :)

SamErde · 2026-04-25T08:40:38Z

What if we removed the "Skipped" and "Not Tested" cards from the top, but also reduce the "Total tests" by the sum of (Skipped + Not Tested)? I still feel like the top row of cards is too busy and makes it harder to see the important details.

Mynster9361 · 2026-04-25T09:15:04Z

What if we removed the "Skipped" and "Not Tested" cards from the top, but also reduce the "Total tests" by the sum of (Skipped + Not Tested)? I still feel like the top row of cards is too busy and makes it harder to see the important details.

Sure can do will properly do it a bit later today or tomorrow

On the "Total Tests" it will now take the total amount of tests and minus (-) with "Skipped" and "Not Tested" Clicking the diffrent cards wioll now apply to the status filter (video attached in my comment as that is easier to show like that) In order to accomplice this i had to move the State of Status "selectedStatus" out to the HomePage.tsx so both the "MtTestSummary.jsx" and the "TestResultsTable.jsx" can utilize the same state rather than having to deal with overwriting each other and updating each other on selection Co-authored-by: Copilot <copilot@github.com>

Mynster9361 · 2026-04-26T20:35:09Z

@SamErde

removed "Skipped" and "Not Tested" cards from the top.
On the "Total Tests" it will now take the total amount of tests and minus (-) with "Skipped" and "Not Tested"

Clicking the diffrent cards wioll now apply to the status filter (video attached in my comment as that is easier to show like that)

2026-04-26.22-27-45.mp4

In order to accomplice this i had to move the State of Status "selectedStatus" out to the HomePage.tsx so both the "MtTestSummary.jsx" and the "TestResultsTable.jsx" can utilize the same state rather than having to deal with overwriting each other and updating each other on selection

codacy-production · 2026-04-26T20:35:34Z

Not up to standards ⛔

_{NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer}
_{TIP This summary will be updated as you push new changes.}

Copilot

Pull request overview

Copilot reviewed 5 out of 7 changed files in this pull request and generated 6 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

…ake sure that was working as intended aswell. including a new video as the ui now highlights selected cards instead of making them darker. Co-authored-by: Copilot <copilot@github.com>

Mynster9361 · 2026-04-26T20:54:35Z

@SamErde

removed "Skipped" and "Not Tested" cards from the top. On the "Total Tests" it will now take the total amount of tests and minus (-) with "Skipped" and "Not Tested"

Clicking the diffrent cards wioll now apply to the status filter (video attached in my comment as that is easier to show like that)

2026-04-26.22-27-45.mp4
In order to accomplice this i had to move the State of Status "selectedStatus" out to the HomePage.tsx so both the "MtTestSummary.jsx" and the "TestResultsTable.jsx" can utilize the same state rather than having to deal with overwriting each other and updating each other on selection

Applied Copilots suggestions and added a comment on this one

#1659 (comment)

also here is an updated video of how it looks after copilots suggestions

2026-04-26.22-52-28.mp4

SamErde · 2026-04-26T21:49:22Z

Amazing! I think it's ready to go out. Going to run a test as well.

Copilot

Pull request overview

Copilot reviewed 5 out of 7 changed files in this pull request and generated 4 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

… summary cards - MtBlocksArea: remove unused Tremor imports (Text, ListItem, CategoryBar) and unused testSummaryColors constant - MtTestSummary: remove unused heroicon imports (ArchiveBoxIcon, ForwardIcon) - MtTestSummary: introduce adjustedTotal (clamped >=0) to prevent NaN/negative display in Total tests metric and percentage denominator - MtTestSummary: add role, tabIndex, onKeyDown (Enter/Space), aria-label, and aria-pressed to interactive cards when onStatusChange is present Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Mynster9361 and others added 14 commits April 4, 2026 20:21

Update CIS readme to v6.0.1 - checking changes and updates to diffren…

8930042

…t test to verify existing test is updated to new framework version

Update Changes to exisiting scripts that had a change from v5.0.0 to …

99ed396

…v6.0.1 next up going through existing content and markdown details

Update split out test from 1 cmd'let to 2 cmd'lets so we can have the…

bc1ed61

… diffrent cis tests

Update docs to the descriptions in Foundations document to streamline…

5248bf6

… all of them and reference to CIS Microsoft 365 Foundations Benchmark v6.0.1 in Tests

fix copilot suggestions applied

296877c

fix seems it has been a while since the readme for cis test coverage …

e334707

…was updated so a few was missing in the list even though they were implemented

fix copilot suggestions

26cdafa

fix wording in readme

4a675e4

Update move comment based help into functions, Update readme.md links

821593d

fix build documentation script did not copy content into version 2 of…

0ce3219

… the website which means the links would be broken when building the maester application in docusaurus @SamErde please take a look at this one and see if it is up to par :)

Merge branch 'main' into pr/1585

e86d1ac

Fixes

f296bec

Merge branch 'main' of https://github.com/Mynster9361/maester

2bd8b20

added investigate to the ui and skipped the places it was missing and…

dbfa88a

… modified the testResults.ts for better visibility to investigatecount

Mynster9361 requested a review from a team as a code owner April 15, 2026 21:44

SamErde requested a review from Copilot April 15, 2026 23:11

Copilot started reviewing on behalf of SamErde April 15, 2026 23:11 View session

Copilot AI reviewed Apr 15, 2026

View reviewed changes

Comment thread report/src/lib/testResults.ts

Comment thread report/src/components/MtBlocksArea.jsx Outdated

removed skipped from donut chart and added

ed01e15

SamErde approved these changes Apr 16, 2026

View reviewed changes

SamErde requested a review from merill April 16, 2026 20:09

Merge branch 'maester365:main' into main

e5a3089

SamErde added this to the v2.1 milestone Apr 20, 2026

Mynster9361 requested review from SamErde and Copilot April 26, 2026 20:36

Copilot started reviewing on behalf of Mynster9361 April 26, 2026 20:36 View session

Copilot AI reviewed Apr 26, 2026

View reviewed changes

applied copilot suggestions also rebuild the reporttemplate.html to m…

cfdbace

…ake sure that was working as intended aswell. including a new video as the ui now highlights selected cards instead of making them darker. Co-authored-by: Copilot <copilot@github.com>

SamErde requested a review from Copilot April 26, 2026 21:50

Copilot started reviewing on behalf of SamErde April 26, 2026 21:51 View session

SamErde approved these changes Apr 26, 2026

View reviewed changes

Copilot AI reviewed Apr 26, 2026

View reviewed changes

Comment thread report/src/components/MtBlocksArea.jsx Outdated

Comment thread report/src/components/MtTestSummary.jsx

Comment thread report/src/components/MtTestSummary.jsx

Comment thread report/src/components/MtTestSummary.jsx

SamErde merged commit e710ad2 into maester365:main Apr 27, 2026
3 of 4 checks passed

Conversation

Mynster9361 commented Apr 15, 2026

Description

Contribution Checklist

Uh oh!

codacy-production Bot commented Apr 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Not up to standards ⛔

Uh oh!

Mynster9361 commented Apr 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

merill commented Apr 16, 2026

Uh oh!

Mynster9361 commented Apr 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Mynster9361 commented Apr 16, 2026

Uh oh!

SamErde left a comment

Choose a reason for hiding this comment

Uh oh!

Mynster9361 commented Apr 16, 2026

Uh oh!

SamErde commented Apr 17, 2026

Uh oh!

Mynster9361 commented Apr 17, 2026

Uh oh!

SamErde commented Apr 25, 2026

Uh oh!

Mynster9361 commented Apr 25, 2026

Uh oh!

Mynster9361 commented Apr 26, 2026

Uh oh!

codacy-production Bot commented Apr 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Not up to standards ⛔

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Mynster9361 commented Apr 26, 2026

Uh oh!

SamErde commented Apr 26, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

codacy-production Bot commented Apr 15, 2026 •

edited

Loading

Mynster9361 commented Apr 15, 2026 •

edited

Loading

Mynster9361 commented Apr 16, 2026 •

edited

Loading

codacy-production Bot commented Apr 26, 2026 •

edited

Loading