Fix critical dice rendering with ggplot2 >= 4.0, prepare v1.2.0#10
Merged
Fix critical dice rendering with ggplot2 >= 4.0, prepare v1.2.0#10
Conversation
Register drawDetails.DiceGrob S3 method in NAMESPACE so grid dispatches to the custom drawing code. Without this, neither tiles nor pips were rendered on ggplot2 4.x. Also fix invisible pips when fill is not mapped (colour defaulted to NA instead of black). Additional changes for CRAN v1.2.0: - Add inst/CITATION matching Bioinformatics publication - Quote package names in DESCRIPTION Title/Description - Remove redundant Author/Maintainer fields - Regenerate demo output plots
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Register drawDetails.DiceGrob S3 method in NAMESPACE so grid dispatches to the custom drawing code. Without this, neither tiles nor pips were rendered on ggplot2 4.x.
Also fix invisible pips when fill is not mapped (colour defaulted to NA instead of black).
Additional changes for CRAN v1.2.0: